Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/databricks insert by period #44

Merged
merged 4 commits into from
Apr 30, 2024

Conversation

matt-winkler
Copy link
Contributor

@matt-winkler matt-winkler commented Apr 26, 2024

  • changes to dbt_project.yml to add databricks related macro search
  • adds example profile for databricks
  • databricks macro override to remove the schema when creating the relation (otherwise got an error)
  • modified materialization code to get rows affected response specific to how databricks returns it (in data and not in response like the other adapters).
  • adds a get_rows_inserted macro to handle variance in response for databricks adapter vs. others

@matt-winkler matt-winkler requested a review from dbeatty10 April 26, 2024 16:41
@matt-winkler matt-winkler requested a review from b-per April 29, 2024 16:55
Copy link
Contributor

@b-per b-per left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

I would just maybe recommend updating the README to mention that it should work across Redshift, Postgres, Snowflake, BigQuery and Databricks ; instead of saying it just works for Redshift

Happy for you to merge.

@matt-winkler matt-winkler merged commit 29cea5f into main Apr 30, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants