Updated metric_input_measure to reflect correctly on what it can be #161
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dave-connors-3
previously approved these changes
Sep 4, 2024
@dave-connors-3 Done! Seems like pushing that commit dismissed your approval. Mind taking a look again? Also, I know this is schema is reflected on the IDE, after I merge this, what's the process/timeline for this being in prod IDE? Thank you 🙏 |
dave-connors-3
approved these changes
Sep 11, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Context
In dbt and in SL, the definition of the metric_input_measure can be either a string or an object. There is some logic to convert the string to an object if that is provided. However, in the schema it shows that it can only be an object. This is causing warnings to show up on the IDE even though it is parseable.