Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add +docs to seeds and snapshots #135

Merged
merged 2 commits into from
May 1, 2024
Merged

Add +docs to seeds and snapshots #135

merged 2 commits into from
May 1, 2024

Conversation

grahamwetzler
Copy link
Contributor

I tested in dbt 1.7 and both seeds and snapshots support docs config in dbt_project.yml

dave-connors-3
dave-connors-3 previously approved these changes Apr 29, 2024
View reviewed changes
Copy link
Contributor

@dave-connors-3 dave-connors-3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@dave-connors-3
Copy link
Contributor

spoke too soon! @grahamwetzler looks like all you'll need to do is add the same key to both spots you already added it without the + in front. We allow either "plussed" or "unplussed" configs, so we have a CI check to always makes sure we have both!

@dave-connors-3 dave-connors-3 self-requested a review April 30, 2024 13:25
@joellabes joellabes merged commit d6a8f37 into dbt-labs:main May 1, 2024
25 checks passed
@grahamwetzler grahamwetzler deleted the docs-config branch May 1, 2024 02:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joellabes joellabes joellabes approved these changes

@dave-connors-3 dave-connors-3 Awaiting requested review from dave-connors-3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@grahamwetzler @dave-connors-3 @joellabes