Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

be less explicit in source regex #9936

Merged
merged 1 commit into from
Apr 15, 2024
Merged

be less explicit in source regex #9936

merged 1 commit into from
Apr 15, 2024

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Apr 15, 2024

resolves None

Problem

Our build is failing because the regex is not finding anything.

Solution

Make the regex less explicit and match the regex we're already using for the wheel.

Checklist

  • I have read the contributing guide and understand what's expected of me
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • This PR has no interface changes (e.g. macros, cli, logs, json artifacts, config files, adapter interface, etc) or this PR has already received feedback and approval from Product or DX
  • This PR includes type annotations for new and modified functions

@emmyoop emmyoop requested a review from a team as a code owner April 15, 2024 13:25
@cla-bot cla-bot bot added the cla:yes label Apr 15, 2024
@emmyoop emmyoop changed the title be less explicit be less explicit in source regex Apr 15, 2024
Copy link

codecov bot commented Apr 15, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 88.07%. Comparing base (c53d67d) to head (9be5163).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #9936      +/-   ##
==========================================
- Coverage   88.13%   88.07%   -0.07%     
==========================================
  Files         178      178              
  Lines       22544    22544              
==========================================
- Hits        19870    19856      -14     
- Misses       2674     2688      +14     
Flag Coverage Δ
integration 85.40% <ø> (-0.16%) ⬇️
unit 62.02% <ø> (-0.06%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@aranke aranke left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@emmyoop emmyoop merged commit 7e72cac into main Apr 15, 2024
64 checks passed
@emmyoop emmyoop deleted the er/fix-distribution branch April 15, 2024 13:39
github-actions bot pushed a commit that referenced this pull request Apr 15, 2024
(cherry picked from commit 7e72cac)
Copy link
Contributor

The backport to 1.0.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.0.latest 1.0.latest
# Navigate to the new working tree
cd .worktrees/backport-1.0.latest
# Create a new branch
git switch --create backport-9936-to-1.0.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7e72cace2bed236a99ec872146e397f2a0db7f71
# Push it to GitHub
git push --set-upstream origin backport-9936-to-1.0.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.0.latest

Then, create a pull request where the base branch is 1.0.latest and the compare/head branch is backport-9936-to-1.0.latest.

Copy link
Contributor

The backport to 1.1.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.1.latest 1.1.latest
# Navigate to the new working tree
cd .worktrees/backport-1.1.latest
# Create a new branch
git switch --create backport-9936-to-1.1.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7e72cace2bed236a99ec872146e397f2a0db7f71
# Push it to GitHub
git push --set-upstream origin backport-9936-to-1.1.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.1.latest

Then, create a pull request where the base branch is 1.1.latest and the compare/head branch is backport-9936-to-1.1.latest.

Copy link
Contributor

The backport to 1.2.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.2.latest 1.2.latest
# Navigate to the new working tree
cd .worktrees/backport-1.2.latest
# Create a new branch
git switch --create backport-9936-to-1.2.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7e72cace2bed236a99ec872146e397f2a0db7f71
# Push it to GitHub
git push --set-upstream origin backport-9936-to-1.2.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.2.latest

Then, create a pull request where the base branch is 1.2.latest and the compare/head branch is backport-9936-to-1.2.latest.

Copy link
Contributor

The backport to 1.6.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.6.latest 1.6.latest
# Navigate to the new working tree
cd .worktrees/backport-1.6.latest
# Create a new branch
git switch --create backport-9936-to-1.6.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7e72cace2bed236a99ec872146e397f2a0db7f71
# Push it to GitHub
git push --set-upstream origin backport-9936-to-1.6.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.6.latest

Then, create a pull request where the base branch is 1.6.latest and the compare/head branch is backport-9936-to-1.6.latest.

Copy link
Contributor

The backport to 1.4.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.4.latest 1.4.latest
# Navigate to the new working tree
cd .worktrees/backport-1.4.latest
# Create a new branch
git switch --create backport-9936-to-1.4.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7e72cace2bed236a99ec872146e397f2a0db7f71
# Push it to GitHub
git push --set-upstream origin backport-9936-to-1.4.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.4.latest

Then, create a pull request where the base branch is 1.4.latest and the compare/head branch is backport-9936-to-1.4.latest.

Copy link
Contributor

The backport to 1.3.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.3.latest 1.3.latest
# Navigate to the new working tree
cd .worktrees/backport-1.3.latest
# Create a new branch
git switch --create backport-9936-to-1.3.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7e72cace2bed236a99ec872146e397f2a0db7f71
# Push it to GitHub
git push --set-upstream origin backport-9936-to-1.3.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.3.latest

Then, create a pull request where the base branch is 1.3.latest and the compare/head branch is backport-9936-to-1.3.latest.

Copy link
Contributor

The backport to 1.5.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.5.latest 1.5.latest
# Navigate to the new working tree
cd .worktrees/backport-1.5.latest
# Create a new branch
git switch --create backport-9936-to-1.5.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7e72cace2bed236a99ec872146e397f2a0db7f71
# Push it to GitHub
git push --set-upstream origin backport-9936-to-1.5.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.5.latest

Then, create a pull request where the base branch is 1.5.latest and the compare/head branch is backport-9936-to-1.5.latest.

Copy link
Contributor

The backport to 1.6.latest failed:

The process '/usr/bin/git' failed with exit code 1

To backport manually, run these commands in your terminal:

# Fetch latest updates from GitHub
git fetch
# Create a new working tree
git worktree add .worktrees/backport-1.6.latest 1.6.latest
# Navigate to the new working tree
cd .worktrees/backport-1.6.latest
# Create a new branch
git switch --create backport-9936-to-1.6.latest
# Cherry-pick the merged commit of this pull request and resolve the conflicts
git cherry-pick -x --mainline 1 7e72cace2bed236a99ec872146e397f2a0db7f71
# Push it to GitHub
git push --set-upstream origin backport-9936-to-1.6.latest
# Go back to the original working tree
cd ../..
# Delete the working tree
git worktree remove .worktrees/backport-1.6.latest

Then, create a pull request where the base branch is 1.6.latest and the compare/head branch is backport-9936-to-1.6.latest.

emmyoop added a commit that referenced this pull request Apr 15, 2024
emmyoop added a commit that referenced this pull request Apr 15, 2024
emmyoop added a commit that referenced this pull request Apr 15, 2024
emmyoop added a commit that referenced this pull request Apr 15, 2024
emmyoop added a commit that referenced this pull request Apr 15, 2024
emmyoop added a commit that referenced this pull request Apr 15, 2024
emmyoop added a commit that referenced this pull request Apr 15, 2024
emmyoop added a commit that referenced this pull request Apr 15, 2024
(cherry picked from commit 7e72cac)

Co-authored-by: Emily Rockman <emily.rockman@dbtlabs.com>
emmyoop added a commit that referenced this pull request Apr 15, 2024
emmyoop added a commit that referenced this pull request Apr 15, 2024
emmyoop added a commit that referenced this pull request Apr 15, 2024
emmyoop added a commit that referenced this pull request Apr 15, 2024
emmyoop added a commit that referenced this pull request Apr 15, 2024
emmyoop added a commit that referenced this pull request Apr 15, 2024
emmyoop added a commit that referenced this pull request Apr 15, 2024
* be less explicit (#9936)

* 1.0 build without the core suffix but we want to ignore it
@aranke aranke mentioned this pull request Jul 12, 2024
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants