Rename tests -> data_tests for model-level + versions #9412
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #9411
Problem
We now expect data tests to be defined in blocks named
data_tests
. For back compat, we need to supporttests
(previous name). To that end, we've added logic for validation (can't have both) and renaming (old → new).However, this is not working for tests defined at the model-level, and tests defined on specific
versions
of a versioned model.Solution
Generalize the validation/renaming logic, and apply it everywhere that a
tests
block can be defined.Checklist