remove adapter.get_compiler

.changes/unreleased/Breaking Changes-20231127-114757.yaml

@@ -0,0 +1,6 @@
+kind: Breaking Changes
+body: Remove adapter.get_compiler interface
+time: 2023-11-27T11:47:57.443202-05:00
+custom:
+  Author: michelleark
+  Issue: "9148"

core/dbt/adapters/base/impl.py

@@ -1370,11 +1370,6 @@ def post_model_hook(self, config: Mapping[str, Any], context: Any) -> None:
         """
         pass
 
-    def get_compiler(self):
-        from dbt.compilation import Compiler
-
-        return Compiler(self.config)
-
     # Methods used in adapter tests
     def update_column_sql(
         self,

core/dbt/adapters/protocol.py

@@ -8,21 +8,17 @@
     Generic,
     TypeVar,
     Tuple,
-    Dict,
-    Any,
 )
 from typing_extensions import Protocol
 
 import agate
 
 from dbt.adapters.contracts.connection import Connection, AdapterRequiredConfig, AdapterResponse
-from dbt.contracts.graph.nodes import ResultNode, ManifestNode
+from dbt.contracts.graph.nodes import ResultNode
 from dbt.contracts.graph.model_config import BaseConfig
 from dbt.contracts.graph.manifest import Manifest
 from dbt.contracts.relation import Policy, HasQuoting
 
-from dbt.graph import Graph
-
 
 @dataclass
 class AdapterConfig(BaseConfig):
@@ -50,24 +46,10 @@ def create_from(cls: Type[Self], config: HasQuoting, node: ResultNode) -> Self:
         ...
 
 
-class CompilerProtocol(Protocol):
-    def compile(self, manifest: Manifest, write=True) -> Graph:
-        ...
-
-    def compile_node(
-        self,
-        node: ManifestNode,
-        manifest: Manifest,
-        extra_context: Optional[Dict[str, Any]] = None,
-    ) -> ManifestNode:
-        ...
-
-
 AdapterConfig_T = TypeVar("AdapterConfig_T", bound=AdapterConfig)
 ConnectionManager_T = TypeVar("ConnectionManager_T", bound=ConnectionManagerProtocol)
 Relation_T = TypeVar("Relation_T", bound=RelationProtocol)
 Column_T = TypeVar("Column_T", bound=ColumnProtocol)
-Compiler_T = TypeVar("Compiler_T", bound=CompilerProtocol)
 
 
 # TODO CT-211
@@ -78,7 +60,6 @@ class AdapterProtocol(  # type: ignore[misc]
         ConnectionManager_T,
         Relation_T,
         Column_T,
-        Compiler_T,
     ],
 ):
     # N.B. Technically these are ClassVars, but mypy doesn't support putting type vars in a
@@ -153,6 +134,3 @@ def execute(
         self, sql: str, auto_begin: bool = False, fetch: bool = False
     ) -> Tuple[AdapterResponse, agate.Table]:
         ...
-
-    def get_compiler(self) -> Compiler_T:
-        ...

core/dbt/compilation.py

@@ -1,4 +1,3 @@
-import argparse
 import json
 
 import networkx as nx  # type: ignore
@@ -34,7 +33,6 @@
 from dbt.node_types import NodeType, ModelLanguage
 from dbt.common.events.format import pluralize
 import dbt.tracking
-import dbt.task.list as list_task
 import sqlparse
 
 graph_file_name = "graph.gpickle"
@@ -485,11 +483,8 @@ def compile(self, manifest: Manifest, write=True, add_test_edges=False) -> Graph
         if write:
             self.write_graph_file(linker, manifest)
 
-        # Do not print these for ListTask's
-        if not (
-            self.config.args.__class__ == argparse.Namespace
-            and self.config.args.cls == list_task.ListTask
-        ):
+        # Do not print these for list command
+        if self.config.args.which != "list":
             stats = _generate_stats(manifest)
             print_compile_stats(stats)
 

core/dbt/task/base.py

@@ -8,10 +8,10 @@
 from pathlib import Path
 from typing import Any, Dict, List, Optional, Type, Union
 
+from dbt.compilation import Compiler
 import dbt.common.exceptions.base
 import dbt.exceptions
 from dbt import tracking
-from dbt.adapters.factory import get_adapter
 from dbt.config import RuntimeConfig, Project
 from dbt.config.profile import read_profile
 from dbt.constants import DBT_PROJECT_FILE_NAME
@@ -161,17 +161,15 @@ def __init__(self, args, config, manifest: Optional[Manifest] = None) -> None:
         super().__init__(args, config)
         self.graph: Optional[Graph] = None
         self.manifest = manifest
+        self.compiler = Compiler(self.config)
 
     def compile_manifest(self):
         if self.manifest is None:
             raise DbtInternalError("compile_manifest called before manifest was loaded")
 
         start_compile_manifest = time.perf_counter()
 
-        # we cannot get adapter in init since it will break rpc #5579
-        adapter = get_adapter(self.config)
-        compiler = adapter.get_compiler()
-        self.graph = compiler.compile(self.manifest)
+        self.graph = self.compiler.compile(self.manifest)
 
         compile_time = time.perf_counter() - start_compile_manifest
         if dbt.tracking.active_user is not None:
@@ -196,6 +194,7 @@ def __init__(self, node) -> None:
 class BaseRunner(metaclass=ABCMeta):
     def __init__(self, config, adapter, node, node_index, num_nodes) -> None:
         self.config = config
+        self.compiler = Compiler(config)
         self.adapter = adapter
         self.node = node
         self.node_index = node_index

core/dbt/task/build.py

@@ -5,7 +5,6 @@
 from .seed import SeedRunner as seed_runner
 from .test import TestRunner as test_runner
 
-from dbt.adapters.factory import get_adapter
 from dbt.contracts.results import NodeStatus
 from dbt.common.exceptions import DbtInternalError
 from dbt.graph import ResourceTypeSelector
@@ -129,6 +128,4 @@ def get_runner_type(self, node):
     def compile_manifest(self):
         if self.manifest is None:
             raise DbtInternalError("compile_manifest called before manifest was loaded")
-        adapter = get_adapter(self.config)
-        compiler = adapter.get_compiler()
-        self.graph = compiler.compile(self.manifest, add_test_edges=True)
+        self.graph = self.compiler.compile(self.manifest, add_test_edges=True)

core/dbt/task/compile.py

@@ -40,8 +40,7 @@ def execute(self, compiled_node, manifest):
         )
 
     def compile(self, manifest):
-        compiler = self.adapter.get_compiler()
-        return compiler.compile_node(self.node, manifest, {})
+        return self.compiler.compile_node(self.node, manifest, {})
 
 
 class CompileTask(GraphRunnableTask):

core/dbt/task/run.py

@@ -315,8 +315,10 @@
         return False
 
     def get_hook_sql(self, adapter, hook, idx, num_hooks, extra_context) -> str:
-        compiler = adapter.get_compiler()
-        compiled = compiler.compile_node(hook, self.manifest, extra_context)
+        if self.manifest is None:
+            raise DbtInternalError("compile_node called before manifest was loaded")
+
+        compiled = self.compiler.compile_node(hook, self.manifest, extra_context)
         statement = compiled.compiled_code
         hook_index = hook.index or num_hooks
         hook_obj = get_hook(statement, index=hook_index)

core/dbt/task/sql.py

@@ -37,8 +37,7 @@
         pass
 
     def compile(self, manifest):
-        compiler = self.adapter.get_compiler()
-        return compiler.compile_node(self.node, manifest, {}, write=False)
+        return self.compiler.compile_node(self.node, manifest, {}, write=False)
 
     @abstractmethod
     def execute(self, compiled_node, manifest) -> SQLResult: