Replace tracking events: project_id, adapter_info
#7231
Conversation
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
core/dbt/tracking.py
Outdated
| INVOCATION_ENV_SPEC = "iglu:com.dbt/invocation_env/jsonschema/1-0-0" | ||
| PACKAGE_INSTALL_SPEC = "iglu:com.dbt/package_install/jsonschema/1-0-0" | ||
| RPC_REQUEST_SPEC = "iglu:com.dbt/rpc_request/jsonschema/1-0-1" | ||
| ADAPTER_INFO_SPEC = "iglu:com.dbt/adapter_info/jsonschema/1-0-0" |
There was a problem hiding this comment.
If you haven't already, I think we'll need to add these two new validation schemas to https://github.com/dbt-labs/iglu.sinter-collect.com
Doc: https://www.notion.so/dbtlabs/Add-new-metrics-to-tracking-in-dbt-3484cc31b8f449dfa2e960d2bbb15afe
There was a problem hiding this comment.
Yeppers.
https://github.com/dbt-labs/iglu.sinter-collect.com/pull/67 although there seems to be an issue with circle CI we'll need to fix if we want to enforce the checks there.
| INVOCATION_ENV_SPEC = "iglu:com.dbt/invocation_env/jsonschema/1-0-0" | ||
| INVOCATION_SPEC = "iglu:com.dbt/invocation/jsonschema/1-0-2" | ||
| LOAD_ALL_TIMING_SPEC = "iglu:com.dbt/load_all_timing/jsonschema/1-0-3" | ||
| PACKAGE_INSTALL_SPEC = "iglu:com.dbt/package_install/jsonschema/1-0-0" |
There was a problem hiding this comment.
alphabetical order, nice 👍
| The events outlined here exist to support "very very old versions of dbt-core, which expected to look directly at the HEAD branch of this github repo to find validation schemas". | ||
|
|
||
| Eventually these should go away (see https://github.com/dbt-labs/dbt-core/issues/7228) |
iknox-fa
changed the title
project_id, adapter_type, adapter_unique_id
iknox-fa
changed the title
project_id, adapter_type, adapter_unique_idproject_id, adapter_info
| dbt.tracking.track_project_id({"project_id": project_id}) | ||
| dbt.tracking.track_adapter_info( | ||
| { | ||
| "adapter_type": adapter_type, | ||
| "adapter_unique_id": adapter_unique_id, | ||
| } | ||
| ) |
There was a problem hiding this comment.
If project_id, adapter_type, and adapter_unique_id can be None, would we still want to fire these tracking events with only Nones?
There was a problem hiding this comment.
I assume so, but that's just mimicking the logic that was in place previously. @jtcohen6, thoughts?
| dbt.tracking.track_project_id({"project_id": project_id}) | ||
| dbt.tracking.track_adapter_info( | ||
| { | ||
| "adapter_type": adapter_type, | ||
| "adapter_unique_id": adapter_unique_id, | ||
| } | ||
| ) |
iknox-fa
deleted the
iknox/CT-1368-1368-GH-6097-6098-replace-tracking-events
branch
Resolves #6097 resolves #6098
Description
Replaces the
project id,adapter_type, andadapter_unique_idevents fields removed during the Click refactor due to timing issues. These values will now be generated in the init of the BaseTask since it's the earliest place we can get that info reliably.Checklist
changie newto create a changelog entry