CT 1894 log partial parsing var changes and sort cli vars before hashing #6713

gshank · 2023-01-24T19:23:36Z

resolves #6710

Description

If the order of vars passed on the command line changes, then partial parsing will be aborted. Sort the vars before hashing in order to avoid unnecessary reparsing.

Checklist

I have read the contributing guide and understand what's expected of me
I have signed the CLA
I have run this code in development and it appears to resolve the stated issue
This PR includes tests, or tests are not required/relevant for this PR
I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR
I have run changie new to create a changelog entry

heysweet · 2023-01-24T19:27:18Z

Thank you so much for adding this logging (and the argument normalization!), it'll be super helpful!

core/dbt/events/types.py

Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com>

core/dbt/parser/manifest.py

dbeatty10

Looks good to me 👍

jtcohen6 · 2023-01-26T12:12:44Z

@gshank Is this something you'd feel comfortable backporting for inclusion in a v1.4.x patch release? The changes look quite minor:

new logging
functional change to sort & stringify vars before hashing

(cc @bossnunta)

gshank · 2023-01-26T18:10:42Z

Yes, should be pretty straightforward to backport. Will do that.

…ing (#6713) * Log information about vars_hash, normalize cli_vars before hashing * Changie * Add to test_events.py * Update core/dbt/events/types.py Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com> (cherry picked from commit a34521e)

…t cli vars before hashing (#6758) * CT 1894 log partial parsing var changes and sort cli vars before hashing (#6713) * Log information about vars_hash, normalize cli_vars before hashing * Changie

gshank added 2 commits January 24, 2023 14:18

Log information about vars_hash, normalize cli_vars before hashing

82c75d2

Changie

bd036a0

gshank requested review from a team as code owners January 24, 2023 19:23

gshank requested review from emmyoop and stu-k January 24, 2023 19:23

cla-bot bot added the cla:yes label Jan 24, 2023

Add to test_events.py

bbb4f3c

gshank requested review from peterallenwebb and removed request for stu-k January 25, 2023 14:56

dbeatty10 reviewed Jan 25, 2023

View reviewed changes

core/dbt/events/types.py Outdated Show resolved Hide resolved

Update core/dbt/events/types.py

b5ff783

Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com>

dbeatty10 reviewed Jan 25, 2023

View reviewed changes

core/dbt/parser/manifest.py Show resolved Hide resolved

dbeatty10 approved these changes Jan 25, 2023

View reviewed changes

peterallenwebb approved these changes Jan 25, 2023

View reviewed changes

gshank merged commit a34521e into main Jan 25, 2023

gshank deleted the ct-1894-log_partial_parsing_var_changes branch January 25, 2023 22:47

gshank added the backport 1.4.latest label Jan 26, 2023

github-actions bot mentioned this pull request Jan 26, 2023

[Backport 1.4.latest] CT 1894 log partial parsing var changes and sort cli vars before hashing #6758

Merged

iknox-fa mentioned this pull request Jan 30, 2023

testing merge strat - do not merge ns/add to committer list #6783

Closed

6 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

CT 1894 log partial parsing var changes and sort cli vars before hashing #6713

CT 1894 log partial parsing var changes and sort cli vars before hashing #6713

gshank commented Jan 24, 2023

heysweet commented Jan 24, 2023

dbeatty10 left a comment

jtcohen6 commented Jan 26, 2023

gshank commented Jan 26, 2023

CT 1894 log partial parsing var changes and sort cli vars before hashing #6713

CT 1894 log partial parsing var changes and sort cli vars before hashing #6713

Conversation

gshank commented Jan 24, 2023

Description

Checklist

heysweet commented Jan 24, 2023

dbeatty10 left a comment

Choose a reason for hiding this comment

jtcohen6 commented Jan 26, 2023

gshank commented Jan 26, 2023