Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

CT 1886 include adapter_response in NodeFinished log message #6709

Merged
merged 2 commits into from
Jan 24, 2023
Merged

CT 1886 include adapter_response in NodeFinished log message #6709

merged 2 commits into from
Jan 24, 2023

Conversation

gshank
Copy link
Contributor

@gshank gshank commented Jan 24, 2023

resolves #6703

Description

Include adapter_response dictionary as a dictionary of strings in the NodeFinished log event.

Checklist

@gshank gshank requested review from a team as code owners January 24, 2023 17:00
@cla-bot cla-bot bot added the cla:yes label Jan 24, 2023
@gshank gshank requested a review from jtcohen6 January 24, 2023 17:00
@gshank gshank merged commit e2ccf01 into main Jan 24, 2023
@gshank gshank deleted the ct-1886-log_adapter_response branch January 24, 2023 19:25
@github-actions github-actions bot mentioned this pull request Jan 24, 2023
Merged
github-actions bot pushed a commit that referenced this pull request Jan 24, 2023
@gshank @github-actions
CT 1886 include adapter_response in NodeFinished log message (#6709)
5fbb833 
* Include adapter_response in run_result in NodeFinished log event

* Changie

(cherry picked from commit e2ccf01)
gshank added a commit that referenced this pull request Jan 24, 2023
@github-actions @gshank
CT 1886 include adapter_response in NodeFinished log message (#6709) (#…
9700ff1 
…6714)

* Include adapter_response in run_result in NodeFinished log event

* Changie

(cherry picked from commit e2ccf01)

Co-authored-by: Gerda Shank <gerda@dbtlabs.com>
@iknox-fa iknox-fa mentioned this pull request Jan 30, 2023
Closed
6 tasks
@colin-rogers-dbt colin-rogers-dbt mentioned this pull request Mar 10, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emmyoop emmyoop emmyoop approved these changes

@peterallenwebb peterallenwebb Awaiting requested review from peterallenwebb peterallenwebb is a code owner automatically assigned from dbt-labs/core-team

@ChenyuLInx ChenyuLInx Awaiting requested review from ChenyuLInx ChenyuLInx was automatically assigned from dbt-labs/core-group

@jtcohen6 jtcohen6 Awaiting requested review from jtcohen6

Assignees
No one assigned
Labels
backport 1.4.latest cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CT-1886] Include adapter_response in RunResultMsg
2 participants
@gshank @emmyoop