-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
convert 037_external_references #6589
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
external_schema = unique_schema + 'z' | ||
project.run_sql(f'create schema "{external_schema}"') | ||
project.run_sql(f'create table "{external_schema}"."external" (id integer)') | ||
project.run_sql(f'insert into "{external_schema}"."external" values (1), (2)') |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are (1)
and (2)
placeholders?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
they are concrete values of id
being inserted into the "{external_schema}"."external"
table
resolves #6574
Description
Checklist
changie new
to create a changelog entry