Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix event level regression #6556

Merged
merged 3 commits into from
Jan 9, 2023
Merged

Conversation

peterallenwebb
Copy link
Contributor

resolves #6501

Description

This change modifies the way the InvalidDisabledTargetInTestNode event is fired, so that the level in 1.4 matches dbt's historical behavior. Since InvalidDisabledTargetInTestNode was created by combining two separate events which had different levels, the new event is sometimes fired at the debug level and other times at the warning level.

Checklist

@peterallenwebb peterallenwebb requested review from a team as code owners January 9, 2023 21:20
@cla-bot cla-bot bot added the cla:yes label Jan 9, 2023
@peterallenwebb peterallenwebb merged commit 294def2 into main Jan 9, 2023
@peterallenwebb peterallenwebb deleted the paw/ct-6501-error-level-regression branch January 9, 2023 23:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-1740] [Regression] Warning for tests on disabled resources should be DebugLevel, not WarnLevel
2 participants