Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add deprecation decorator #6540

Merged
merged 3 commits into from
Jan 9, 2023
Merged

add deprecation decorator #6540

merged 3 commits into from
Jan 9, 2023

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Jan 6, 2023

resolves #6393

Description

Checklist

@cla-bot cla-bot bot added the cla:yes label Jan 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2023

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@emmyoop emmyoop added the Skip Changelog Skips GHA to check for changelog file label Jan 8, 2023
@emmyoop
Copy link
Member Author

emmyoop commented Jan 9, 2023

Here is the output of the deprecation:

(env-protobuf) emily@Emily-Rockman basic-dbt % dbt deps
16:09:38  Running with dbt=1.4.0-b1
16:09:38  [WARNING]: `raise_parsing_error` is deprecated and will be removed in dbt-core version 1.5.0

Adapter maintainers can resolve this deprecation by using `raise ParsingException` directly instead.
See https://github.com/dbt-labs/dbt-core/issues/6393 for more details
16:09:38  Encountered an error:
Parsing Error
  Some fake msg
(env-protobuf) emily@Emily-Rockman basic-dbt %

@emmyoop emmyoop removed the Skip Changelog Skips GHA to check for changelog file label Jan 9, 2023
@emmyoop emmyoop marked this pull request as ready for review January 9, 2023 16:17
@emmyoop emmyoop requested a review from a team January 9, 2023 16:17
@emmyoop emmyoop requested review from a team as code owners January 9, 2023 16:17
@emmyoop emmyoop requested review from aranke, gshank and peterallenwebb and removed request for aranke January 9, 2023 16:17
Copy link
Contributor

@gshank gshank left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@emmyoop emmyoop merged commit 02c2047 into main Jan 9, 2023
@emmyoop emmyoop deleted the er/ct-1612-deprecation-2 branch January 9, 2023 18:09
@emmyoop emmyoop mentioned this pull request Jan 9, 2023
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-1612] Add deprecation decorator for functions
2 participants