Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[CT-1693] Port severity test to Pytest #6537

Merged
merged 2 commits into from
Jan 6, 2023
Merged

[CT-1693] Port severity test to Pytest #6537

merged 2 commits into from
Jan 6, 2023

Conversation

aranke
Copy link
Member

@aranke aranke commented Jan 6, 2023 •
edited
Loading

resolves #6466

Description

Checklist

@aranke aranke requested a review from a team as a code owner January 6, 2023 19:27
@aranke aranke requested review from gshank and emmyoop January 6, 2023 19:27
@cla-bot cla-bot bot added the cla:yes label Jan 6, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Jan 6, 2023

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@aranke aranke requested a review from ChenyuLInx January 6, 2023 19:29
ChenyuLInx
ChenyuLInx approved these changes Jan 6, 2023
View reviewed changes
Copy link
Contributor

@ChenyuLInx ChenyuLInx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! I remember you mentioned parameterized test, I guess it is not for this one?

@aranke
Copy link
Member Author

aranke commented Jan 6, 2023

Looks great! I remember you mentioned parameterized test, I guess it is not for this one?

The code is clean enough as-is, parameterizing would make things harder to read, so decided against it here.
In general, I've found parameterization to work best when asserting a single output across many inputs.

@aranke aranke merged commit 94d6d19 into main Jan 6, 2023
@aranke aranke deleted the ct-1693 branch January 6, 2023 19:59
@iknox-fa iknox-fa mentioned this pull request Jan 30, 2023
Closed
6 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChenyuLInx ChenyuLInx ChenyuLInx approved these changes

@gshank gshank Awaiting requested review from gshank gshank was automatically assigned from dbt-labs/core-group

@emmyoop emmyoop Awaiting requested review from emmyoop emmyoop was automatically assigned from dbt-labs/core-group

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CT-1693] 045_test_severity_tests
2 participants
@aranke @ChenyuLInx