Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add back validator_error_message #6465

Merged
merged 1 commit into from
Dec 20, 2022
Merged

add back validator_error_message #6465

merged 1 commit into from
Dec 20, 2022

Conversation

emmyoop
Copy link
Member

@emmyoop emmyoop commented Dec 20, 2022

Description

When cleaning up exceptions I converted validator_error_message from a function to a method on RuntimeException. This leaves it as a method but also adds it back as a function to not break adapters. #6413 will add the decorator to the function to mark it as deprecated.

Checklist

@emmyoop emmyoop added the Skip Changelog Skips GHA to check for changelog file label Dec 20, 2022
@emmyoop emmyoop requested a review from a team as a code owner December 20, 2022 16:18
@cla-bot cla-bot bot added the cla:yes label Dec 20, 2022
@emmyoop emmyoop requested review from mikealfare and McKnight-42 and removed request for MichelleArk and nathaniel-may December 20, 2022 16:19
Copy link
Contributor

@McKnight-42 McKnight-42 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, still think we should go ahead and update adapter repos as we can.

@emmyoop emmyoop merged commit c39ea80 into main Dec 20, 2022
@emmyoop emmyoop deleted the er/add-func-back branch December 20, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants