Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Treat dense text blobs as binary for git grep #6462

Merged
merged 1 commit into from
Dec 21, 2022

Conversation

dbeatty10
Copy link
Contributor

@dbeatty10 dbeatty10 commented Dec 20, 2022

resolves #6294

Description

Without this PR, try the following:

git grep "unrendered_config" tests

Not fun!

Then try again with this PR.

Much better:

$ git grep "unrendered_config" tests                 
Binary file tests/functional/artifacts/data/state/v1/manifest.json matches
Binary file tests/functional/artifacts/data/state/v2/manifest.json matches
Binary file tests/functional/artifacts/data/state/v3/manifest.json matches
Binary file tests/functional/artifacts/data/state/v4/manifest.json matches
Binary file tests/functional/artifacts/data/state/v5/manifest.json matches
Binary file tests/functional/artifacts/data/state/v6/manifest.json matches
Binary file tests/functional/artifacts/data/state/v7/manifest.json matches
Binary file tests/functional/artifacts/data/state/v8/manifest.json matches
tests/functional/artifacts/expected_manifest.py:                "unrendered_config": unrendered_model_config,
tests/functional/artifacts/expected_manifest.py:                "unrendered_config": unrendered_second_config,
tests/functional/artifacts/expected_manifest.py:                "unrendered_config": unrendered_seed_config,
...

Checklist

@dbeatty10 dbeatty10 requested a review from a team as a code owner December 20, 2022 02:39
@cla-bot cla-bot bot added the cla:yes label Dec 20, 2022
@dbeatty10 dbeatty10 added the ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering label Dec 20, 2022
Copy link
Contributor

@ChenyuLInx ChenyuLInx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!

@dbeatty10 dbeatty10 merged commit 9ecb6e5 into main Dec 21, 2022
@dbeatty10 dbeatty10 deleted the dbeatty/simplify-git-grep branch December 21, 2022 00:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[CT-1539] [Feature] Ignore manifest.json files for git grep
2 participants