-
Notifications
You must be signed in to change notification settings - Fork 1.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Prevent docs gen workflow on forks #6390
Conversation
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome, @stu-k ! 💪
Thanks for the screenshot -- made it easy to see it working 🧠
Approving this proactively assuming that all CI tests will pass.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good - just remove the changelog before merging!
kind: Under the Hood | ||
body: Prevent doc gen workflow from running on forks | ||
time: 2022-12-06T09:40:15.301984-06:00 | ||
custom: | ||
Author: stu-k | ||
Issue: "6386" | ||
PR: "6390" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change doesn't need a changelog since it's not something actually released.
resolves #6386
Description
Adds a conditional to the
check_gen
step of the CLI API doc gen workflow to prevent being run off of forks. Tested on a fork:Checklist
changie new
to create a changelog entry