Remove PR from most changelog kinds #6374

emmyoop · 2022-12-03T03:49:49Z

resolves #6332

Description

Removes changelog from all but Dependency and Security kinds. Removes issue from those.

Allows for multiple issues (or PRs depending on kind) to be entered for a single change.

Note: I also found that the changelog-bot was using the Dependency kind while the .changie.yaml was using Dependencies. I synced them to be Dependencies.

Checklist

I have read the contributing guide and understand what's expected of me
I have signed the CLA
I have run this code in development and it appears to resolve the stated issue
This PR includes tests, or tests are not required/relevant for this PR
I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR
I have run changie new to create a changelog entry

github-actions · 2022-12-03T03:50:07Z

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

emmyoop · 2022-12-08T17:57:59Z

CONTRIBUTING.md

+Once changie is installed and your PR is created for a new feature, simply run `changie new` and changie will walk you through the process of creating a changelog entry.  Commit the file that's created and your changelog entry is complete!
+
+If you are contributing to a feature already in progress, you will modify the changie yaml file in `dbt/.changes/unreleased` related to your change.  If you need help finding this file, please ask!


@dbeatty10 can I get your eyes on this wording please?

Personally, I prefer stand-alone blocks of code I can copy-paste into my terminal. This is easier for me than picking text out of the middle of sentences. That being said, I've noticed many people prefer to just "copy" with their eyes and then "paste" by typing it with their fingers!

Some ideas for light edits:

Once changie is installed and your PR is created for a new feature, simply run the following command and changie will walk you through the process of creating a changelog entry:

changie new

Commit the file that's created and your changelog entry is complete!

If you are contributing to a feature already in progress, you will modify the changie yaml file in dbt/.changes/unreleased/ related to your change. If you need help finding this file, please ask within the discussion for the pull request!

CONTRIBUTING.md

Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com>

dbeatty10

Exciting work @emmyoop 🚀

* update changie to require issue or pr, and allow multiple * remove extraneous data from changelog files. * allow for multiple PR/issues to be entered * update contributing guide * remove issue number from bot changelogs * update format of PR * fix dependency changelogs * remove extra line * remove extra lines, tweak contributor wording * Update CONTRIBUTING.md Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com> Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com>

* update changie to require issue or pr, and allow multiple * remove extraneous data from changelog files. * allow for multiple PR/issues to be entered * update contributing guide * remove issue number from bot changelogs * update format of PR * fix dependency changelogs * remove extra line * remove extra lines, tweak contributor wording * Update CONTRIBUTING.md Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com> Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com> # Conflicts: # .changes/unreleased/Dependency-20220923-000646.yaml # .changes/unreleased/Dependency-20221007-000848.yaml # .changes/unreleased/Dependency-20221020-000753.yaml # .changes/unreleased/Dependency-20221026-000910.yaml # .changes/unreleased/Docs-20220908-154157.yaml # .changes/unreleased/Docs-20221007-090656.yaml # .changes/unreleased/Docs-20221017-171411.yaml # .changes/unreleased/Docs-20221116-155743.yaml # .changes/unreleased/Docs-20221202-150523.yaml # .changes/unreleased/Features-20220408-165459.yaml # .changes/unreleased/Features-20220817-154857.yaml # .changes/unreleased/Features-20220912-125935.yaml # .changes/unreleased/Features-20220914-095625.yaml # .changes/unreleased/Features-20220925-211651.yaml # .changes/unreleased/Features-20221003-110705.yaml # .changes/unreleased/Features-20221102-150003.yaml # .changes/unreleased/Features-20221114-185207.yaml # .changes/unreleased/Features-20221130-112913.yaml # .changes/unreleased/Fixes-20220916-104854.yaml # .changes/unreleased/Fixes-20221010-113218.yaml # .changes/unreleased/Fixes-20221011-160715.yaml # .changes/unreleased/Fixes-20221016-173742.yaml # .changes/unreleased/Fixes-20221107-095314.yaml # .changes/unreleased/Fixes-20221115-081021.yaml # .changes/unreleased/Fixes-20221202-164859.yaml # .changes/unreleased/Under the Hood-20220927-194259.yaml # .changes/unreleased/Under the Hood-20220929-134406.yaml # .changes/unreleased/Under the Hood-20221005-120310.yaml # .changes/unreleased/Under the Hood-20221007-094627.yaml # .changes/unreleased/Under the Hood-20221007-140044.yaml # .changes/unreleased/Under the Hood-20221013-181912.yaml # .changes/unreleased/Under the Hood-20221017-151511.yaml # .changes/unreleased/Under the Hood-20221017-155844.yaml # .changes/unreleased/Under the Hood-20221028-104837.yaml # .changes/unreleased/Under the Hood-20221028-110344.yaml # .changes/unreleased/Under the Hood-20221108-074550.yaml # .changes/unreleased/Under the Hood-20221108-115633.yaml # .changes/unreleased/Under the Hood-20221108-133104.yaml # .changes/unreleased/Under the Hood-20221116-130037.yaml

* Remove PR from most changelog kinds (#6374) * update changie to require issue or pr, and allow multiple * remove extraneous data from changelog files. * allow for multiple PR/issues to be entered * update contributing guide * remove issue number from bot changelogs * update format of PR * fix dependency changelogs * remove extra line * remove extra lines, tweak contributor wording * Update CONTRIBUTING.md Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com> Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com> * fix contributor list generation (#6799) * fix merge conflict --------- Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com>

* Remove PR from most changelog kinds (#6374) * update changie to require issue or pr, and allow multiple * remove extraneous data from changelog files. * allow for multiple PR/issues to be entered * update contributing guide * remove issue number from bot changelogs * update format of PR * fix dependency changelogs * remove extra line * remove extra lines, tweak contributor wording * Update CONTRIBUTING.md Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com> Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com> # Conflicts: # .changes/unreleased/Dependency-20220923-000646.yaml # .changes/unreleased/Dependency-20221007-000848.yaml # .changes/unreleased/Dependency-20221020-000753.yaml # .changes/unreleased/Dependency-20221026-000910.yaml # .changes/unreleased/Docs-20220908-154157.yaml # .changes/unreleased/Docs-20221007-090656.yaml # .changes/unreleased/Docs-20221017-171411.yaml # .changes/unreleased/Docs-20221116-155743.yaml # .changes/unreleased/Docs-20221202-150523.yaml # .changes/unreleased/Features-20220408-165459.yaml # .changes/unreleased/Features-20220817-154857.yaml # .changes/unreleased/Features-20220912-125935.yaml # .changes/unreleased/Features-20220914-095625.yaml # .changes/unreleased/Features-20220925-211651.yaml # .changes/unreleased/Features-20221003-110705.yaml # .changes/unreleased/Features-20221102-150003.yaml # .changes/unreleased/Features-20221114-185207.yaml # .changes/unreleased/Features-20221130-112913.yaml # .changes/unreleased/Fixes-20220916-104854.yaml # .changes/unreleased/Fixes-20221010-113218.yaml # .changes/unreleased/Fixes-20221011-160715.yaml # .changes/unreleased/Fixes-20221016-173742.yaml # .changes/unreleased/Fixes-20221107-095314.yaml # .changes/unreleased/Fixes-20221115-081021.yaml # .changes/unreleased/Fixes-20221202-164859.yaml # .changes/unreleased/Under the Hood-20220927-194259.yaml # .changes/unreleased/Under the Hood-20220929-134406.yaml # .changes/unreleased/Under the Hood-20221005-120310.yaml # .changes/unreleased/Under the Hood-20221007-094627.yaml # .changes/unreleased/Under the Hood-20221007-140044.yaml # .changes/unreleased/Under the Hood-20221013-181912.yaml # .changes/unreleased/Under the Hood-20221017-151511.yaml # .changes/unreleased/Under the Hood-20221017-155844.yaml # .changes/unreleased/Under the Hood-20221028-104837.yaml # .changes/unreleased/Under the Hood-20221028-110344.yaml # .changes/unreleased/Under the Hood-20221108-074550.yaml # .changes/unreleased/Under the Hood-20221108-115633.yaml # .changes/unreleased/Under the Hood-20221108-133104.yaml # .changes/unreleased/Under the Hood-20221116-130037.yaml * fix contributor list generation (#6799) # Conflicts: # .changie.yaml

* Remove PR from most changelog kinds (#6374) * update changie to require issue or pr, and allow multiple * remove extraneous data from changelog files. * allow for multiple PR/issues to be entered * update contributing guide * remove issue number from bot changelogs * update format of PR * fix dependency changelogs * remove extra line * remove extra lines, tweak contributor wording * Update CONTRIBUTING.md Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com> Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com> * fix contributor list generation (#6799) * fix merge conflict --------- Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com>

emmyoop added 3 commits December 2, 2022 21:41

update changie to require issue or pr, and allow multiple

da39f3c

remove extraneous data from changelog files.

7cf2d78

allow for multiple PR/issues to be entered

855acc2

cla-bot bot added the cla:yes label Dec 3, 2022

emmyoop added 2 commits December 2, 2022 21:58

update contributing guide

930a5fb

remove issue number from bot changelogs

3b33b42

emmyoop commented Dec 8, 2022

View reviewed changes

emmyoop added 4 commits December 11, 2022 06:54

update format of PR

7e020a3

fix dependency changelogs

59d3cd4

remove extra line

95d7a9b

remove extra lines, tweak contributor wording

17a0b41

emmyoop closed this Dec 11, 2022

emmyoop reopened this Dec 11, 2022

emmyoop marked this pull request as ready for review December 12, 2022 13:20

emmyoop requested review from leahwicz and a team as code owners December 12, 2022 13:20

emmyoop requested a review from McKnight-42 December 12, 2022 13:20

gshank approved these changes Dec 12, 2022

View reviewed changes

dbeatty10 reviewed Dec 12, 2022

View reviewed changes

CONTRIBUTING.md Outdated Show resolved Hide resolved

Update CONTRIBUTING.md

4a0da4f

Co-authored-by: Doug Beatty <44704949+dbeatty10@users.noreply.github.com>

dbeatty10 reviewed Dec 12, 2022

View reviewed changes

emmyoop merged commit 0fbbc89 into main Dec 12, 2022

emmyoop deleted the er/ct-1562-changie-updates branch December 12, 2022 19:18

iknox-fa mentioned this pull request Jan 30, 2023

testing merge strat - do not merge ns/add to committer list #6783

Closed

6 tasks

This was referenced Jan 31, 2023

[BACKPORT] fix contributor list generation (#6799) #6807

Merged

[BACKPORT] fix contributor list generation (#6799) #6808

Merged

[BACKPORT] fix contributor list generation (#6799) #6809

Merged

[BACKPORT] fix contributor list generation (#6799) #6810

Merged

emmyoop mentioned this pull request Apr 18, 2024

fix changelogs #9975

Merged

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Remove PR from most changelog kinds #6374

Remove PR from most changelog kinds #6374

emmyoop commented Dec 3, 2022 •

edited

Loading

github-actions bot commented Dec 3, 2022

emmyoop Dec 8, 2022

dbeatty10 Dec 8, 2022

dbeatty10 left a comment

		Once changie is installed and your PR is created for a new feature, simply run `changie new` and changie will walk you through the process of creating a changelog entry. Commit the file that's created and your changelog entry is complete!

		If you are contributing to a feature already in progress, you will modify the changie yaml file in `dbt/.changes/unreleased` related to your change. If you need help finding this file, please ask!

Remove PR from most changelog kinds #6374

Remove PR from most changelog kinds #6374

Conversation

emmyoop commented Dec 3, 2022 • edited Loading

Description

Checklist

github-actions bot commented Dec 3, 2022

emmyoop Dec 8, 2022

Choose a reason for hiding this comment

dbeatty10 Dec 8, 2022

Choose a reason for hiding this comment

dbeatty10 left a comment

Choose a reason for hiding this comment

emmyoop commented Dec 3, 2022 •

edited

Loading