Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DepsTask with Click #6260

Merged
merged 9 commits into from
Nov 22, 2022
Merged

DepsTask with Click #6260

merged 9 commits into from
Nov 22, 2022

Conversation

MichelleArk
Copy link
Contributor

@MichelleArk MichelleArk commented Nov 16, 2022 •
edited
Loading

resolves ##5547

Description

Checklist

@cla-bot cla-bot bot added the cla:yes label Nov 16, 2022
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

ChenyuLInx
ChenyuLInx reviewed Nov 16, 2022
View reviewed changes
Copy link
Contributor

@ChenyuLInx ChenyuLInx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great!

core/dbt/deps/resolver.py Outdated Show resolved Hide resolved
core/dbt/task/base.py Outdated Show resolved Hide resolved
core/dbt/task/deps.py Show resolved Hide resolved
@MichelleArk MichelleArk changed the title deps with click: first pass DepsTask with Click Nov 18, 2022
@MichelleArk MichelleArk marked this pull request as ready for review November 22, 2022 02:16
@MichelleArk MichelleArk requested a review from a team November 22, 2022 02:16
@MichelleArk MichelleArk requested review from a team as code owners November 22, 2022 02:16
@ChenyuLInx ChenyuLInx added the Skip Changelog Skips GHA to check for changelog file label Nov 22, 2022
ChenyuLInx
ChenyuLInx approved these changes Nov 22, 2022
View reviewed changes
Copy link
Contributor

@ChenyuLInx ChenyuLInx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great with one small question regarding _fetch_metadata

core/dbt/deps/local.py Show resolved Hide resolved
core/dbt/task/deps.py Show resolved Hide resolved
@MichelleArk MichelleArk merged commit 44b457c into feature/click-cli Nov 22, 2022
@MichelleArk MichelleArk deleted the arky/deps-with-click branch November 22, 2022 22:53
@jtcohen6 jtcohen6 mentioned this pull request Nov 23, 2022
Closed
This was referenced Jan 31, 2023
Merged
Closed
This was referenced Feb 8, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChenyuLInx ChenyuLInx ChenyuLInx approved these changes

@gshank gshank Awaiting requested review from gshank gshank was automatically assigned from dbt-labs/core-team

Assignees
No one assigned
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MichelleArk @ChenyuLInx