Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Run dbt on WebAssembly #6146

Closed
wants to merge 4 commits into from
Closed

Run dbt on WebAssembly #6146

wants to merge 4 commits into from

Conversation

arieldbt
Copy link

Description

Fixes for the linter on this PR: #5803

Checklist

@arieldbt arieldbt requested a review from a team as a code owner October 26, 2022 03:08
@arieldbt arieldbt requested a review from a team October 26, 2022 03:08
@arieldbt arieldbt requested review from a team as code owners October 26, 2022 03:08
@cla-bot cla-bot bot added the cla:yes label Oct 26, 2022
@arieldbt
Copy link
Author

unit tests pass, these integration tests fail for me locally (not sure if my setup is bad):

full logs are here: https://gist.github.com/arieldbt/7a5d742ecfe64e75f17bbb9d898e33b1

============================================ short test summary info ============================================
FAILED tests/adapter/dbt/tests/adapter/grants/test_model_grants.py::TestModelGrants::test_view_table_grants - assert 0 == 3
FAILED tests/adapter/dbt/tests/adapter/grants/test_incremental_grants.py::TestIncrementalGrants::test_incremental_grants - assert 0 == 3
FAILED tests/adapter/dbt/tests/adapter/grants/test_invalid_grants.py::TestInvalidGrants::test_invalid_grants - dbt.exceptions.ParsingException: Parsing Error
FAILED tests/adapter/dbt/tests/adapter/grants/test_snapshot_grants.py::TestSnapshotGrants::test_snapshot_grants - dbt.exceptions.ParsingException: Parsing Error
FAILED tests/adapter/dbt/tests/adapter/grants/test_seed_grants.py::TestSeedGrants::test_seed_grants - dbt.exceptions.ParsingException: Parsing Error
========================================= 5 failed, 76 passed in 20.55s =========================================
ERROR: InvocationError for command /Users/ariel/code/dbt-core/.tox/py-integration/bin/python -m pytest --cov=core -nauto tests/adapter (exited with code 1)
____________________________________________________ summary ____________________________________________________
ERROR:   py-integration: commands failed

@arieldbt
Copy link
Author

Annnnnd I got the integration tests to pass by running this command instead (updated the full log):

https://gist.github.com/arieldbt/7a5d742ecfe64e75f17bbb9d898e33b1

% DBT_TEST_USER_1=dbt_test_user_1 DBT_TEST_USER_2=dbt_test_user_2 DBT_TEST_USER_3=dbt_test_user_3 make integration > integration.log 2>&1

@jtcohen6
Copy link
Contributor

@arieldbt Thanks for reopening! Most of these changes look reasonable. I'm excited that they actually leave us with cleaner / more pluggable interfaces for things like external requests. And the new click CLI → top-level APIs should make it even easier to invoke dbt-core programmatically, as a library.

Considerations:

  • The dynamic inclusion/exclusion of "dbt-extractor~=0.4.1" as an installation dependency might move us even further away from our ability to eventually support Poetry / pyproject.toml: [CT-1067] [Spike] Impact/feasibility checks for pyproject.toml #5696
  • We'd want some sort of CI check to verify that dbt-on-pyodide works on an ongoing basis. Otherwise, we risk making changes that break compatibility without knowing.

Ultimately, I think the folks on the Execution team are best situated to review this.

@jtcohen6 jtcohen6 added Team:Execution ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering labels Nov 17, 2022
@emmyoop emmyoop removed their request for review November 18, 2022 19:43
@ChenyuLInx ChenyuLInx removed their request for review December 19, 2022 23:56
@jtcohen6 jtcohen6 added Refinement Maintainer input needed and removed Team:Execution ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering labels Jan 5, 2023
@jtcohen6
Copy link
Contributor

Going to close this one for now. It remains a very cool idea—but not something we can make immediate progress on, nor do we have a tangible use case that we can invest in supporting on an ongoing basis.

@jtcohen6 jtcohen6 closed this Jun 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Refinement Maintainer input needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants