Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging works with Click #6088

Merged
merged 16 commits into from
Oct 25, 2022
Merged

Logging works with Click #6088

merged 16 commits into from
Oct 25, 2022

Conversation

iknox-fa
Copy link
Contributor

resolves #5530
resolves CT-906

Description

Logging support for new Click CLI

Checklist

@cla-bot cla-bot bot added the cla:yes label Oct 17, 2022
@github-actions
Copy link
Contributor

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

@iknox-fa iknox-fa marked this pull request as ready for review October 18, 2022 17:09
@iknox-fa iknox-fa requested a review from a team October 18, 2022 17:09
@iknox-fa iknox-fa requested review from a team as code owners October 18, 2022 17:09
@iknox-fa iknox-fa requested review from stu-k and gshank October 18, 2022 17:09
ChenyuLInx
ChenyuLInx approved these changes Oct 24, 2022
View reviewed changes
Copy link
Contributor

@ChenyuLInx ChenyuLInx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with minor adjustments

core/dbt/clients/system.py Outdated Show resolved Hide resolved
core/dbt/main.py Outdated Show resolved Hide resolved
@iknox-fa iknox-fa merged commit 1ec54ab into feature/click-cli Oct 25, 2022
@iknox-fa iknox-fa deleted the iknox/CT-906-GH-5530-Logging-works-w-click branch October 25, 2022 19:14
@jtcohen6 jtcohen6 mentioned this pull request Nov 1, 2022
Closed
@aranke aranke mentioned this pull request Jan 31, 2023
Merged
6 tasks
@aranke aranke mentioned this pull request Jan 31, 2023
Closed
6 tasks
This was referenced Feb 8, 2023
Merged
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@stu-k stu-k stu-k approved these changes

@ChenyuLInx ChenyuLInx ChenyuLInx approved these changes

@gshank gshank Awaiting requested review from gshank gshank was automatically assigned from dbt-labs/core-team

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@iknox-fa @ChenyuLInx @stu-k