Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix typo in util.py #6037

Merged
merged 3 commits into from
Dec 20, 2022
Merged

Fix typo in util.py #6037

merged 3 commits into from
Dec 20, 2022

Conversation

eltociear
Copy link
Contributor

Description

identifer -> identifier

Checklist

identifer -> identifier
@eltociear eltociear requested a review from a team as a code owner October 10, 2022 13:48
@eltociear eltociear requested review from emmyoop and iknox-fa October 10, 2022 13:48
@cla-bot
Copy link

cla-bot bot commented Oct 10, 2022

Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA.

In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin.

CLA has not been signed by users: @eltociear

@eltociear
Copy link
Contributor Author

I signed CLA.

@leahwicz
Copy link
Contributor

@cla-bot check

@cla-bot cla-bot bot added the cla:yes label Oct 27, 2022
@cla-bot
Copy link

cla-bot bot commented Oct 27, 2022

The cla-bot has been summoned, and re-checked this pull request!

@jtcohen6
Copy link
Contributor

@eltociear Thanks for the PR! We wouldn't normally require a changelog entry for changes to non-functional code, but we also want to give you credit for the contribution :) think you could create a changelog entry and push it up?

@jtcohen6 jtcohen6 added the ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering label Nov 17, 2022
@eltociear
Copy link
Contributor Author

@jtcohen6
Thank you for contacting!
I created a change log entry using changie.

Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Update the changelog and this should be good to go! Thanks for the contribution.

.changes/unreleased/Fixes-20221117-220320.yaml Outdated Show resolved Hide resolved
@emmyoop emmyoop self-requested a review December 19, 2022 19:10
@emmyoop emmyoop merged commit 1e35339 into dbt-labs:main Dec 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes ready_for_review Externally contributed PR has functional approval, ready for code review from Core engineering
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants