New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Tracking works with Click #5972

Merged

ChenyuLInx merged 19 commits into feature/click-cli from chenyu/tracking_for_click

Oct 25, 2022

Contributor

ChenyuLInx commented Sep 28, 2022 •

edited

Loading

resolves #5534

Description

Checklist

I have read the contributing guide and understand what's expected of me
I have signed the CLA
I have run this code in development and it appears to resolve the stated issue
This PR includes tests, or tests are not required/relevant for this PR
I have opened an issue to add/update docs, or docs changes are not required/relevant for this PR
I have run changie new to create a changelog entry

cla-bot bot added the cla:yes label

Contributor

github-actions bot commented Sep 28, 2022

Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide.

ChenyuLInx commented

View reviewed changes

core/dbt/cli/main.py Outdated Show resolved Hide resolved

iknox-fa and others added 4 commits

October 5, 2022 16:18


          Mostly working, WIP for Chenyu

da541cc


          moving args to cli level

5547cca


          explicitly pass flag

cd041b7


          initialize tracking in click

391e8bc

ChenyuLInx force-pushed the chenyu/tracking_for_click branch from c97d074 to 391e8bc Compare

October 5, 2022 23:22


          revert update to project_dir

c8aea10

ChenyuLInx requested review from iknox-fa and removed request for iknox-fa

October 5, 2022 23:26

ChenyuLInx added the Skip Changelog label

ChenyuLInx marked this pull request as ready for review

October 6, 2022 22:31

ChenyuLInx requested a review from a team

October 6, 2022 22:31

ChenyuLInx requested a review from a team as a code owner

October 6, 2022 22:31

ChenyuLInx requested review from stu-k, lostmygithubaccount and iknox-fa

October 6, 2022 22:31

ChenyuLInx added 4 commits

October 7, 2022 14:37


          refactor tracking

b0eaeda


          add logic for credential

fada6d0


          fix command

46bc493


          more refactor

4aec2da

iknox-fa reviewed

View reviewed changes

core/dbt/cli/flags.py Show resolved Hide resolved

iknox-fa reviewed

View reviewed changes

core/dbt/cli/main.py Outdated Show resolved Hide resolved

iknox-fa reviewed

View reviewed changes

core/dbt/cli/main.py Outdated Show resolved Hide resolved

iknox-fa reviewed

View reviewed changes

core/dbt/cli/main.py Outdated Show resolved Hide resolved

iknox-fa reviewed

View reviewed changes

core/dbt/cli/main.py Outdated Show resolved Hide resolved

iknox-fa reviewed

View reviewed changes

core/dbt/tracking.py Outdated Show resolved Hide resolved

iknox-fa suggested changes

View reviewed changes

Contributor

iknox-fa left a comment

A few small changes

iknox-fa changed the base branch from main to feature/click-cli

October 18, 2022 19:01


          updated flags to reflect latest code

200f29b

iknox-fa changed the base branch from feature/click-cli to iknox/CT-906-GH-5530-Logging-works-w-click

October 18, 2022 19:08

iknox-fa added 5 commits

October 18, 2022 14:14


          update and sort imports

b7e2051


          removed un-needed logging code from cherry-pick

8ed08d8


          removed necessity for profile and creds in tracking setup

84ee012


          fix tests

b17c59f


          update legacy flags so tests keep passing

79f043a

iknox-fa changed the base branch from iknox/CT-906-GH-5530-Logging-works-w-click to feature/click-cli

October 18, 2022 20:35

This was referenced Oct 18, 2022

[CT-1367] New tracking event: Adapter info #6097

Closed

[CT-1368] New tracking event: Project ID #6098

Closed

iknox-fa changed the title ~~tracking works with click~~ Tracking works with Click

iknox-fa added 2 commits

October 18, 2022 16:29


          updated tracking to be less coupled w flags

0cb1fb8


          Merge branch 'feature/click-cli' of github.com:dbt-labs/dbt-core into…

a87ba48

… chenyu/tracking_for_click

iknox-fa self-requested a review

October 18, 2022 21:45

iknox-fa and others added 2 commits

October 19, 2022 10:16


          missed a broken test

3f65e61


          remove project_id and adapter info from track_run

ad47d02

stu-k reviewed

View reviewed changes

Contributor

stu-k left a comment

Nothing stands out 👍
I'll leave for @iknox-fa to approve!

iknox-fa approved these changes

View reviewed changes

Contributor

iknox-fa left a comment

LGTM!

ChenyuLInx merged commit 847c0b9 into feature/click-cli

ChenyuLInx deleted the chenyu/tracking_for_click branch

October 25, 2022 17:41

jtcohen6 mentioned this pull request

[CT-910] Tracking works with Click #5534

Closed

aranke mentioned this pull request

[CT-921] dbt compile works in click (#5545) #6586

Merged

6 tasks

ChenyuLInx added a commit that referenced this pull request


          Click snapshot as click command (#5972) (#6640)

1913eac

This was referenced Jan 31, 2023

[CT-1947] Alias --models to --select for all commands except dbt ls #6787

Merged

Move docs to run on PR merge #6805

Closed

This was referenced Feb 8, 2023

Fix Click CLI test DB Name #6895

Merged

Fix Project Env Var Tests #6916

Merged

Merge feature/click-cli into main #6931

Merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla:yes Skip Changelog