Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Flags work with Click #5790

Merged
merged 25 commits into from
Sep 19, 2022
Merged

Flags work with Click #5790

merged 25 commits into from
Sep 19, 2022

Conversation

iknox-fa
Copy link
Contributor

@iknox-fa iknox-fa commented Sep 8, 2022 •
edited
Loading

resolves #5529

Description

Adds a new version of the flags module.

Checklist

@cla-bot cla-bot bot added the cla:yes label Sep 8, 2022
@dbt-labs dbt-labs deleted a comment from github-actions bot Sep 8, 2022
@iknox-fa iknox-fa marked this pull request as ready for review September 8, 2022 17:38
@iknox-fa iknox-fa requested a review from a team as a code owner September 8, 2022 17:38
stu-k
stu-k reviewed Sep 8, 2022
View reviewed changes
core/dbt/cli/params.py Outdated Show resolved Hide resolved
core/dbt/cli/params.py Outdated Show resolved Hide resolved
core/dbt/cli/params.py Outdated Show resolved Hide resolved
@iknox-fa iknox-fa requested a review from stu-k September 8, 2022 19:27
ChenyuLInx
ChenyuLInx reviewed Sep 8, 2022
View reviewed changes
Copy link
Contributor

@ChenyuLInx ChenyuLInx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just pointed out some TODOs that we might want to track

core/dbt/cli/main.py Outdated Show resolved Hide resolved
core/dbt/cli/params.py Show resolved Hide resolved
core/dbt/cli/main.py Outdated Show resolved Hide resolved
core/dbt/cli/params.py Outdated Show resolved Hide resolved
core/dbt/cli/params.py Show resolved Hide resolved
core/dbt/cli/params.py Show resolved Hide resolved
iknox-fa
iknox-fa commented Sep 9, 2022
View reviewed changes
core/dbt/cli/flags.py Outdated Show resolved Hide resolved
@iknox-fa iknox-fa force-pushed the iknox/CT-905-flags-work-w-click branch from 4d10a45 to a73d274 Compare September 9, 2022 17:19
@iknox-fa iknox-fa requested a review from emmyoop September 9, 2022 19:16
ChenyuLInx
ChenyuLInx approved these changes Sep 12, 2022
View reviewed changes
Copy link
Contributor

@ChenyuLInx ChenyuLInx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@iknox-fa iknox-fa changed the base branch from main to 1.2.latest September 14, 2022 15:30
@iknox-fa iknox-fa requested a review from a team September 14, 2022 15:30
@iknox-fa iknox-fa requested review from a team and leahwicz as code owners September 14, 2022 15:30
@iknox-fa iknox-fa changed the base branch from 1.2.latest to main September 14, 2022 15:31
@iknox-fa iknox-fa merged commit 4c29d48 into main Sep 19, 2022
@iknox-fa iknox-fa deleted the iknox/CT-905-flags-work-w-click branch September 19, 2022 17:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChenyuLInx ChenyuLInx ChenyuLInx approved these changes

@jtcohen6 jtcohen6 Awaiting requested review from jtcohen6

@stu-k stu-k Awaiting requested review from stu-k

@emmyoop emmyoop Awaiting requested review from emmyoop

@leahwicz leahwicz Awaiting requested review from leahwicz

Assignees
No one assigned
Labels
cla:yes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[CT-905] Flags work with Click
5 participants
@iknox-fa @emmyoop @jtcohen6 @ChenyuLInx @stu-k