Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating backport Action permissions #5121

Merged
merged 1 commit into from
Apr 25, 2022
Merged

Conversation

leahwicz
Copy link
Contributor

Description

This failed for me the other day once I made my latest changes to the Action because it couldn't create a PR because it only had read and not write permissions. This updates the permissions. I ran a test on my personal repo and it worked with this update

Checklist

  • I have signed the CLA
  • I have run this code in development and it appears to resolve the stated issue
  • This PR includes tests, or tests are not required/relevant for this PR
  • I have added information about my change to be included in the CHANGELOG.

@leahwicz leahwicz added the Skip Changelog Skips GHA to check for changelog file label Apr 21, 2022
@leahwicz leahwicz requested a review from emmyoop April 21, 2022 01:15
@cla-bot cla-bot bot added the cla:yes label Apr 21, 2022
Copy link
Member

@emmyoop emmyoop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That makes sense since it creates a new PR.

Out of curiosity do you know why it worked before it got updated?

@leahwicz leahwicz merged commit d1ae9dd into main Apr 25, 2022
@leahwicz leahwicz deleted the leahwicz/backportAction branch April 25, 2022 13:33
@leahwicz
Copy link
Contributor Author

@emmyoop I noticed it had stopped working the other week so that's why I went investigating in the first place and saw the updates to the Action itself. I'm curious if GitHub changed something with permissions that caused this to start failing

agoblet pushed a commit to BigDataRepublic/dbt-core that referenced this pull request May 20, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla:yes Skip Changelog Skips GHA to check for changelog file
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants