add favor-state flag #5017
add favor-state flag #5017
Conversation
|
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin. CLA has not been signed by users: @daniel-murray |
1 similar comment
|
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin. CLA has not been signed by users: @daniel-murray |
|
@cla-bot check |
|
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin. CLA has not been signed by users: @daniel-murray |
|
The cla-bot has been summoned, and re-checked this pull request! |
|
Just adding a big plus one to getting this in! Any update @daniel-murray ? (Sorry for double post on issue too!) |
| @@ -86,6 +86,7 @@ def env_set_path(key: str) -> Optional[Path]: | |||
|
|
|||
| MACRO_DEBUGGING = env_set_truthy("DBT_MACRO_DEBUGGING") | |||
| DEFER_MODE = env_set_truthy("DBT_DEFER_TO_STATE") | |||
| favor_state_MODE = env_set_truthy("DBT_favor_state_STATE") | |||
There was a problem hiding this comment.
This probably should be all upper case to match existing standard
|
@daniel-murray: Is this something that you'd like to move forward? |
|
CLA has been signed off, so hoping we can get this merged soonish! Let me know if you need anything else from me. |
|
The first thing to do is to merge the current state of main, resolve the differences, and update. |
Co-authored-by: josephberni <joseph.berni@gousto.co.uk>
josephberni
force-pushed
the
feature/favor-state
branch
from
57c8f06 to
a5e8f5c
Compare
|
Thanks for your pull request, and welcome to our community! We require contributors to sign our Contributor License Agreement and we don't seem to have your signature on file. Check out this article for more information on why we have a CLA. In order for us to review and merge your code, please submit the Individual Contributor License Agreement form attached above above. If you have questions about the CLA, or if you believe you've received this message in error, don't hesitate to ping @drewbanin. CLA has not been signed by users: @daniel-murray |
|
@josephberni I think we might need @daniel-murray to sign the CLA to get this merged |
|
I still want this real bad :D - any movement here @josephberni ? |
|
I've created a new branch for this change where I am now the owner #5859 Let me know if there is anything else you need from me & sorry @NiallRees it took so long! |
|
closing in favor of #5859 |
Co-authored-by: josephberni joseph.berni@gousto.co.uk
resolves #5016
Description
Add
--favor-stateoption which enables --defer to favor using--statenode even if node exists in current target.This optionally removes the below second
--defercriterion when using the--favor-stateflag.Checklist
Currently in the process of signing the CLA.