Convert source tests #4935
Merged
Convert source tests #4935
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emmyoop
requested review from
ChenyuLInx and
gshank
and removed request for
a team
gshank
approved these changes
Mar 23, 2022
| class TestSourceOverride: | ||
| @pytest.fixture(scope="class", autouse=True) | ||
| def setUp(self, project_root, local_dependency): # noqa: F811 | ||
| write_project_files(project_root, "local_dependency", local_dependency) |
There was a problem hiding this comment.
Nice! I was thinking about how to do the local_dependency thing, and this works very neatly.
| @pytest.fixture(scope="class") | ||
| def project_config_update(self): | ||
| return { | ||
| "config-version": 2, |
There was a problem hiding this comment.
Nit... We don't need config-version here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
converts 042_sources_tests and 059_source_overrides_tests as part of the source config work. This PR just converts the existing tests.
Checklist