Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix restrict-access to not restrict within same package #11014

Merged
merged 5 commits into from
Nov 21, 2024
Merged

Conversation

gshank
Copy link
Contributor

@gshank gshank commented Nov 19, 2024

Resolves #10134

Problem

Check for invalid refs was too broad, disallowing access within a package.

Solution

Check for package not being the same when applying restrict access flag.

Checklist

  • I have read the contributing guide and understand what's expected of me.
  • I have run this code in development, and it appears to resolve the stated issue.
  • This PR includes tests, or tests are not required or relevant for this PR.
  • This PR has no interface changes (e.g., macros, CLI, logs, JSON artifacts, config files, adapter interface, etc.) or this PR has already received feedback and approval from Product or DX.
  • This PR includes type annotations for new and modified functions.

@gshank gshank requested a review from a team as a code owner November 19, 2024 21:26
@cla-bot cla-bot bot added the cla:yes label Nov 19, 2024
Copy link

codecov bot commented Nov 19, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 89.06%. Comparing base (f080346) to head (7e2b2ab).
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #11014      +/-   ##
==========================================
- Coverage   89.13%   89.06%   -0.08%     
==========================================
  Files         183      183              
  Lines       23646    23646              
==========================================
- Hits        21078    21061      -17     
- Misses       2568     2585      +17     
Flag Coverage Δ
integration 86.39% <ø> (-0.16%) ⬇️
unit 62.77% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
Unit Tests 62.77% <ø> (ø)
Integration Tests 86.39% <ø> (-0.16%) ⬇️
---- 🚨 Try these New Features:

@gshank gshank merged commit ae95759 into main Nov 21, 2024
56 checks passed
@gshank gshank deleted the restrict_access branch November 21, 2024 00:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Projects with restrict-access: true cannot leverage generic tests on private models
2 participants