Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature] Add order_by and limit fields to saved queries #10531

Closed
3 tasks done
plypaul opened this issue Aug 6, 2024 · 0 comments · Fixed by #10532
Closed
3 tasks done

[Feature] Add order_by and limit fields to saved queries #10531

plypaul opened this issue Aug 6, 2024 · 0 comments · Fixed by #10532
Assignees
@plypaul
Labels
enhancement New feature or request semantic Issues related to the semantic layer

Comments

@plypaul
Copy link
Contributor

plypaul commented Aug 6, 2024

Is this your first time submitting a feature request?

  • I have read the expectations for open source contributors
  • I have searched the existing issues, and I could not find an existing issue for this feature
  • I am requesting a straightforward extension of existing dbt functionality, rather than a Big Idea better suited to a discussion

Describe the feature

  • Add a order_by field to saved queries that allow ordering of the results returned.
  • Add a limit field to saved queries that allow limiting of the results returned.

Describe alternatives you've considered

Request from @Jstein77.

Who will this benefit?

Request from @Jstein77.

Are you interested in contributing this feature?

Yes

Anything else?

No response
@plypaul plypaul added enhancement New feature or request triage labels Aug 6, 2024
@plypaul plypaul self-assigned this Aug 6, 2024
plypaul added a commit that referenced this issue Aug 6, 2024
@plypaul
Add change log for #10531.
867b7da
@plypaul plypaul mentioned this issue Aug 6, 2024
Merged
5 tasks
@dbeatty10 dbeatty10 added semantic Issues related to the semantic layer and removed triage labels Aug 9, 2024
plypaul added a commit that referenced this issue Aug 10, 2024
@plypaul
Add change log for #10531.
8389d06
plypaul added a commit that referenced this issue Aug 10, 2024
@plypaul
Add change log for #10531.
aa60b04
plypaul added a commit that referenced this issue Aug 10, 2024
@plypaul
Add change log for #10531.
a163ffa
plypaul added a commit that referenced this issue Aug 12, 2024
@plypaul
Add change log for #10531.
a0db17d
plypaul added a commit that referenced this issue Oct 10, 2024
@plypaul
Add change log for #10531.
473ca1c
plypaul added a commit that referenced this issue Oct 11, 2024
@plypaul
Add change log for #10531.
a47e78b
plypaul added a commit that referenced this issue Oct 15, 2024
@plypaul
Add change log for #10531.
9229660
plypaul added a commit that referenced this issue Oct 15, 2024
@plypaul
Add change log for #10531.
be84c16
plypaul added a commit that referenced this issue Oct 15, 2024
@plypaul
Add change log for #10531.
00b2430
plypaul added a commit that referenced this issue Oct 15, 2024
@plypaul
Add change log for #10531.
4e2c50e
plypaul added a commit that referenced this issue Oct 16, 2024
@plypaul
Add change log for #10531.
c89306e
plypaul added a commit that referenced this issue Oct 17, 2024
@plypaul
Add change log for #10531.
18e4fba
QMalcolm pushed a commit that referenced this issue Oct 17, 2024
@plypaul
Add order_by and limit fields to saved queries (#10532)
8be0635 
* Add `order_by` and `limit` fields to saved queries.

* Update JSON schema

* Add change log for #10531.

* Check order by / limit in saved-query parsing test.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@plypaul plypaul

Labels
enhancement New feature or request semantic Issues related to the semantic layer
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

Add order_by and limit fields to saved queries dbt-labs/dbt-core
2 participants
@plypaul @dbeatty10