Skip to content

Commit

Permalink
updated TODOs with GH issue number
Browse files Browse the repository at this point in the history
  • Loading branch information
iknox-fa committed Dec 6, 2022
1 parent 8635966 commit d334351
Show file tree
Hide file tree
Showing 4 changed files with 4 additions and 4 deletions.
2 changes: 1 addition & 1 deletion core/dbt/task/runnable.py
Original file line number Diff line number Diff line change
Expand Up @@ -141,7 +141,7 @@ def get_selection_spec(self) -> SelectionSpec:
# to the default value for the indirect selection parameter in
# dbt.cli.params.indirect_selection
#
# Doing that is actually a little tricky, so I'm punting it to a new ticket GH# TODO
# Doing that is actually a little tricky, so I'm punting it to a new ticket GH #6397
indirect_selection = getattr(self.args, "INDIRECT_SELECTION", "eager")

if self.args.selector:
Expand Down
2 changes: 1 addition & 1 deletion test/unit/test_graph.py
Original file line number Diff line number Diff line change
Expand Up @@ -304,7 +304,7 @@ def test__dependency_list(self):
# to the default value for the indirect selection parameter in
# dbt.cli.params.indirect_selection
#
# Doing that is actually a little tricky, so I'm punting it to a new ticket GH# TODO
# Doing that is actually a little tricky, so I'm punting it to a new ticket GH #6397
queue = selector.get_graph_queue(parse_difference(None, None, "eager"))

for model_id in model_ids:
Expand Down
2 changes: 1 addition & 1 deletion test/unit/test_graph_selection.py
Original file line number Diff line number Diff line change
Expand Up @@ -130,7 +130,7 @@ def test_run_specs(include, exclude, expected):
# to the default value for the indirect selection parameter in
# dbt.cli.params.indirect_selection
#
# Doing that is actually a little tricky, so I'm punting it to a new ticket GH# TODO
# Doing that is actually a little tricky, so I'm punting it to a new ticket GH #6397
spec = graph_cli.parse_difference(include, exclude, "eager")
selected, _ = selector.select_nodes(spec)

Expand Down
2 changes: 1 addition & 1 deletion test/unit/test_linker.py
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@ def _get_graph_queue(self, manifest, include=None, exclude=None):
# to the default value for the indirect selection parameter in
# dbt.cli.params.indirect_selection
#
# Doing that is actually a little tricky, so I'm punting it to a new ticket GH# TODO
# Doing that is actually a little tricky, so I'm punting it to a new ticket GH #6397
spec = parse_difference(include, exclude, "eager")
return selector.get_graph_queue(spec)

Expand Down

0 comments on commit d334351

Please sign in to comment.