use patch_microbatch_end_time #307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
1 similar comment
|
Thank you for your pull request! We could not find a changelog entry for this change. For details on how to document a change, see the contributing guide. |
QMalcolm
previously approved these changes
Sep 14, 2024
MichelleArk
force-pushed
the
use-patch-microbatch-time-method
branch
from
9e72836 to
993f704
Compare
mikealfare
previously approved these changes
Sep 16, 2024
dbt-tests-adapter/dbt/tests/adapter/incremental/test_incremental_microbatch.py
Outdated
Show resolved
Hide resolved
…nimal Co-authored-by: Mike Alfare <13974384+mikealfare@users.noreply.github.com>
mikealfare
previously approved these changes
Sep 16, 2024
|
Closing this PR. We are first going to move the utility from dbt-core to dbt-common, then do this work |
colin-rogers-dbt
approved these changes
Sep 16, 2024
4 tasks
4 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
resolves #N/A
docs dbt-labs/docs.getdbt.com/#
Problem
Usage of freezegun was not precise enough to just microbatch and caused issues in testing downstream in dbt-snowflake.
Solution
Use new utility to patch just microbatch end time introduced in dbt-labs/dbt-core#10713.
Checklist
Confirmed this fixes things in dbt-snowflake: https://github.com/dbt-labs/dbt-snowflake/actions/runs/10857121125/job/30133020922?pr=1179
Will need a patch release of dbt-test-adapters to get this out!