fix: kms key asset permissions #1101
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: lennartrommeiss <lennart.rommeiss@deutschebahn.com>
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## fix/asset-permissions #1101 +/- ##
========================================================
Coverage ? 71.80%
========================================================
Files ? 3
Lines ? 461
Branches ? 0
========================================================
Hits ? 331
Misses ? 91
Partials ? 39
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
Signed-off-by: lennartrommeiss <lennart.rommeiss@deutschebahn.com>
Signed-off-by: lennartrommeiss <lennart.rommeiss@deutschebahn.com>
markussiebert
merged commit dd38e6b
into
dbsystel:fix/asset-permissions
12 checks passed
markussiebert
added a commit
that referenced
this pull request
Feb 6, 2025
* chore: document how to disable iam generation * chore: typo * chore: self mutation Signed-off-by: github-actions <github-actions@github.com> * fix: asset permissions * fix: kms key asset permissions (#1101) * fix: kms key asset permissions Signed-off-by: lennartrommeiss <lennart.rommeiss@deutschebahn.com> * fix: update tests Signed-off-by: lennartrommeiss <lennart.rommeiss@deutschebahn.com> * fix: update some tests Signed-off-by: lennartrommeiss <lennart.rommeiss@deutschebahn.com> --------- Signed-off-by: lennartrommeiss <lennart.rommeiss@deutschebahn.com> * chore: self mutation Signed-off-by: github-actions <github-actions@github.com> --------- Signed-off-by: github-actions <github-actions@github.com> Signed-off-by: lennartrommeiss <lennart.rommeiss@deutschebahn.com> Co-authored-by: github-actions <github-actions@github.com> Co-authored-by: Lennart Rommeiss <61516567+lenderom@users.noreply.github.com> Co-authored-by: lennartrommeiss <lennart.rommeiss@deutschebahn.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #