Tweak rustfmt config #109
Merged
Tweak rustfmt config #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
newAM
approved these changes
Jan 10, 2024
There was a problem hiding this comment.
I'm ok with nightly rustfmt features, I really like format_code_in_doc_comments myself.
For some reason, we ended up with both a rustfmt.toml and a .rustfmt.toml file. Remove one of them.
The option will merge multiple imports from the same crate. Since it isn't yet stabilized, we need to run `cargo +nightly fmt` to reformat code. Running it on stable will print a warning, but formatting will work nevertheless (just without import merging).
I did this by temporarily adding `format_code_in_doc_comments = true` to the rustfmt config and applying the reformatting. Then, I added all chunks that didn't somehow mangle the formatting of the expectation arrays.
|
@newAM I updated the PR again!
|
newAM
approved these changes
Jan 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See commit messages 🙂
@newAM Do you agree with adding unstable rustfmt options?