Added CPU architecture detection and option

[michael-picard]

This PR adds the ability to pass --arch=arm64 option when installing drivers.
The cpu architecture is detected automatically in DriverFactory::createFromBrowser().
As of today, there is no chromedriver for Linux and arm64 :

• Linux ARM64 support? GoogleChromeLabs/chrome-for-testing#1
• https://issues.chromium.org/issues/374811603

[dbrekelmans]

Looks great! Just a few small suggested changes and I'll be happy to merge it 💪
Take a look at the CI as well and make sure the build succeeds.

Thanks for the contribution!

[dbrekelmans]

@michael-picard Hi, just pinging you in case you didn't get a notification of my review. Good work so far, just a few small changes required!

[michael-picard]

Hi @dbrekelmans sorry fo the late reply, I got swamped this week, I'm gonna work on this today.

[michael-picard]

@dbrekelmans I tried to run the pull_request CI locally using act but it fails on php bdi browser:google-chrome -vvv with the error 'google-chrome: not found'. It would seem "normal" to me since the ca.yml file doesn't install any browsers. Am I misunderstanding something here? Sorry I'm still fairly new in Github actions.

[dbrekelmans]

If you could just resolve the PHPStan and PHPCS failures, I'll take care of the QA checks after merging.

You can run these tools locally by running vendor/bin/phpstan analyse and vendor/bin/phpcs --warning-severity=0

[michael-picard]

Hi @dbrekelmans , it's done.

[michael-picard]

Hi @dbrekelmans I reran phpcbf for browser-driver-installer/src/Cpu/CpuArchitecture.php, looks like the volume mounting of Docker was getting in the way, I had to do remove the extra space manually.

[dbrekelmans]

Thanks @michael-picard!