Generic client callback registration #204
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
refactored WithStartProgramCallback to build RFC_START_PROGRAM as FunctionHandler and allows to register any function as client callback function.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implemented client side function handler registration.
With this PR clients can register function handlers either from a known function (metadata lookup from backend) or by building function metadata at runtime.
The function handlers can be registered in the ConnectionBuilder (method WithFunctionHandler) .
Refactored WithStartProgramCallback of ConnectionBuilder to build RFC_START_PROGRAM as function handler.
AllowStartOfProgram methods on RFcRuntime and Connection are obsolete now and should be removed with next major release.