Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix publish action #582

Merged
merged 2 commits into from
Aug 10, 2024
Merged

Fix publish action #582

merged 2 commits into from
Aug 10, 2024

Conversation

qianl15
Copy link
Member

@qianl15 qianl15 commented Aug 10, 2024

Fix an issue in our Github action where the publish didn't build packages correctly.

Root cause was that I modified the dbos-sdk in package-lock.json to be:

"node_modules/@dbos-inc/dbos-sdk": {
      "resolved": "",
      "link": true
    },

So we must build the root package first.

@qianl15 qianl15 merged commit a86a2c8 into main Aug 10, 2024
14 checks passed
@qianl15 qianl15 deleted the qian/fix-publish branch August 10, 2024 04:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kraftp kraftp kraftp approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@qianl15 @kraftp