Fix Debug Mode Output Check #223
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
devhawk
reviewed
Dec 15, 2023
| @@ -113,10 +113,17 @@ export class WorkflowContextDebug extends DBOSContextImpl implements WorkflowCon | |||
|
|
|||
| const result = await this.#dbosExec.userDatabase.transaction(wrappedTransaction, txnInfo.config); | |||
|
|
|||
| // If returned nothing and the recorded value is also null/undefined, we just return it | |||
| if (result === undefined && !check!.output) { | |||
There was a problem hiding this comment.
what is the ! before check mean?
There was a problem hiding this comment.
Never mind, it's not. the use of ! for both not and "ignore maybe null" threw me
There was a problem hiding this comment.
Maybe explicitly compare check!.output to false to make this clearer?
devhawk
reviewed
Dec 15, 2023
devhawk
approved these changes
Dec 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR solves a minor issue for the debug mode: If a function returns nothing, we record
nullin the database (there's no good way to serialize undefined to a valid JSON string). So when we get the recorded output, we would getnullinstead ofundefined. Therefore, the debugger would incorrectly print out an error message when it comparesundefinedtonullwhen the function returns nothing.This PR updates the debug mode code to handle the
undefinedreturn value.