Configure ssl ca -- setup ssl_sa for developer #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kraftp
reviewed
Dec 8, 2023
| @@ -42,9 +43,18 @@ export async function configureApp(host: string, port: string, dbName: string) { | |||
| return; | |||
| } | |||
|
|
|||
| try { | |||
| // Should we just download and keep the file in the dir instead of downloading everytime ?? | |||
There was a problem hiding this comment.
We can do an "if file not exists" check here to fix this issue.
There was a problem hiding this comment.
No issue if the file exists. We just overwrite it. No big deal. My question was -- should we keep the file in the examples/hello so we never make the rest call ? The downside is that if they change the cert chain , then the file we have might be out of date.
There was a problem hiding this comment.
Oh, I see, I don't think we should keep the file in the repository, downloading it is fine as you said
kraftp
approved these changes
Dec 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.