Adding ExecuteOnReinstall attribute for SystemTools - TemplateFile #21
Conversation
|
|
||
| bool execute = execute_per_condition && ( | ||
| (execute_per_component_install && (attributes & ExecuteOnInstall) && msiInstall.IsInstalling()) | ||
| || (execute_per_component_uninstall && (attributes & ExecuteOnUnInstall) && msiInstall.IsUnInstalling()) | ||
| || (execute_per_component_reinstall && (attributes & ExecuteOnReInstall) && msiInstall.IsReInstalling()) |
There was a problem hiding this comment.
Something going on here with tabs/spaces.
|
It's good. It needs a CHANGELOG entry please (via |
|
Ok - fixed the tabs and added changelog... |
|
Could you squash these commits please? |
|
Done... But pls hold with merging for a while... I want to check sth... |
|
Alright, holding. |
|
Nope - all is fine - you can merge... I had another issue - the file path I am templating need to have double slashes (and I'm using [INSTALLDIR] in WiX). But it seems the author of the project I'm working on just modified msiext for double slashes and made custom build. So now when I build from master branch it's single slash again. I may create another pull request shortly that will add "DoubleSlash" option for TemplateFileProperty |
Adding ExecuteOnReinstall attribute for SystemTools - TemplateFile
|
DoubleSlash sounds like a hack, doubt it will fly here ;) |
|
Merged, thanks for contributing! I will plan to do a release soon, haven't been using this project in a long time. |
Hi there ;)
I needed this feature - in case of same MSI reinstallation or repair - my template file was not changed.
Now it's working fine - I tested it... Pls merge the changes. Thanks ;)