Generate unique, temporary names for socket files in a more robust way. #6
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Thin back-end generates a default socket filename by calling
Tempfile.open
:However, this does more than generate a nicely unique name; it actually creates the file then frees it to be deleted at the close of the block. Garbage collection will delete it next time it runs. (Note that, as far as we know, this hasn't dinged us in production. Maybe the fact that the proxy process has started writing to the file prevents the delete?)
This commit adds a
Utils.tmp_filename
helper for this purpose instead. It's based on ruby 1.9'sDir::Tmpname.make_tmpname
. New specs assert that the generated filename doesn't exist before server start, and that later garbage-collection doesn't delete the socket.