Added --host support
#17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
jwhitcraft
commented
Jan 1, 2015
jwhitcraft
commented
- For when you need to change the ip address.
- Added Tests
- Updated README
| @@ -41,7 +41,8 @@ def build_rack_command | |||
| command.push( | |||
| options[:config], | |||
| '--env', options[:environment].to_s, | |||
| '--port', options[:port].to_s | |||
| '--port', options[:port].to_s, | |||
| '--host', options[:host].to_s | |||
There was a problem hiding this comment.
Nitpick: swap host and port, typically options host comes first.
There was a problem hiding this comment.
This is taken care of: https://github.com/dblock/guard-rack/pull/17/files#diff-46b6856b2f57a5f4eaf3d1e192a5469cR12
|
This is great, thanks. Please update CHANGELOG as well, and squash your commits. |
jwhitcraft
force-pushed
the
host_support
branch
from
b185079 to
c203a22
Compare
| @@ -1,7 +1,7 @@ | |||
| 2.1.0 (Next) | |||
| ============ | |||
|
|
|||
| * Your contribution here. | |||
There was a problem hiding this comment.
Don't delete this, leave it underneath for the next person.
- For when you need to change the ip address. - Added Tests - Updated README - Added to Changelog
jwhitcraft
force-pushed
the
host_support
branch
from
c203a22 to
0d536c5
Compare
|
Thanks! Merging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.