Make the webhook optional #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
allanger
force-pushed
the
wenhook-disable
branch
2 times, most recently
from
f635a23
to
1622a5a
Compare
allanger
changed the title
allanger
force-pushed
the
wenhook-disable
branch
from
1622a5a
to
3bdb942
Compare
allanger
force-pushed
the
wenhook-disable
branch
3 times, most recently
from
336c4fb
to
ac9af31
Compare
Not everybody needs a webhook, so it makes sense to make its creation optional. Also, I've added a very basic test for values, that is checking if the wished files are generated by helm using certain values files. I'd say it's rather a temporary solution, but currently, I don't know a better option Issue: db-operator/db-operator#38
New versions of Kubernetes were released. I've updated them to have ones that are currently actual in the CI pipeline
allanger
force-pushed
the
wenhook-disable
branch
from
ac9af31
to
710787e
Compare
dabde
approved these changes
Aug 8, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Not everybody needs a webhook, so it makes sense to make its creation
optional.
Also, I've added a very basic test for values, that is checking if the
wished files are generated by helm using certain values files. I'd say
it's rather a temporary solution, but currently, I don't know a better
option
Issue: db-operator/db-operator#38