-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add kebab case converter #7
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
soomtong
force-pushed
the
kebab-screaming
branch
from
August 23, 2023 08:24
8eec269
to
d7c3d01
Compare
TaehuiKim
approved these changes
Aug 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
👍
테스트코드에 console.log가 여러군데 찍혀있는데 혹시 필요에 의해 남겨두신걸까요?
역시 지우자는 의견이 나오는군요! |
moonimooni
reviewed
Aug 23, 2023
soomtong
force-pushed
the
kebab-screaming
branch
2 times, most recently
from
August 23, 2023 09:04
45f7521
to
7d2441e
Compare
soomtong
force-pushed
the
kebab-screaming
branch
from
August 23, 2023 09:04
7d2441e
to
2f06c98
Compare
moonimooni
approved these changes
Aug 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR 의 종류는 어떤 것인가요?
수정이 필요하게된 이유가 무엇인가요? (Jira 이슈가 있다면 링크를 연결해주세요)
캐밥 케이스 변환이 필요한 경우가 종종 있어 추가해 봅니다.
어떻게 테스트 하셨나요?
npm t
코드의 실행결과를 볼 수 있는 로그나 이미지가 있다면 첨부해주세요.