Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add kebab case converter #7

Merged
merged 3 commits into from
Aug 23, 2023
Merged

add kebab case converter #7

merged 3 commits into from
Aug 23, 2023

Conversation

soomtong
Copy link
Contributor

PR 의 종류는 어떤 것인가요?

  • 새로운 기능

수정이 필요하게된 이유가 무엇인가요? (Jira 이슈가 있다면 링크를 연결해주세요)

캐밥 케이스 변환이 필요한 경우가 종종 있어 추가해 봅니다.

어떻게 테스트 하셨나요?

npm t

코드의 실행결과를 볼 수 있는 로그나 이미지가 있다면 첨부해주세요.

image

@soomtong soomtong added the enhancement New feature or request label Aug 23, 2023
@soomtong soomtong requested review from 9w, moonimooni and a team August 23, 2023 08:23
@soomtong soomtong self-assigned this Aug 23, 2023
Copy link

@TaehuiKim TaehuiKim left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
테스트코드에 console.log가 여러군데 찍혀있는데 혹시 필요에 의해 남겨두신걸까요?

@soomtong
Copy link
Contributor Author

역시 지우자는 의견이 나오는군요!
제거하겠습니다

README.md Outdated Show resolved Hide resolved
src/kebab-case.spec.ts Outdated Show resolved Hide resolved
@soomtong soomtong force-pushed the kebab-screaming branch 2 times, most recently from 45f7521 to 7d2441e Compare August 23, 2023 09:04
Copy link

@moonimooni moonimooni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@soomtong soomtong merged commit 425c268 into main Aug 23, 2023
1 check passed
@soomtong soomtong deleted the kebab-screaming branch August 23, 2023 09:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants