Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update chart2.0 #128

Merged
merged 6 commits into from
Jun 27, 2019
Merged

Update chart2.0 #128

merged 6 commits into from
Jun 27, 2019

Conversation

GQuirino
Copy link
Contributor

@GQuirino GQuirino commented Jun 24, 2019

update Chart.js to 2.0
Fix warning: unsafe-eval
DeepinScreenshot_select-area_20190624104816
this warning was from v.1 of ChartJs fixed on v2.0
chartjs/Chart.js#2759

Copy link
Contributor

@rbUUbr rbUUbr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GQuirino Great work! Could you please also add info about it to CHANGELOG.md?
cc @davydovanton

@GQuirino
Copy link
Contributor Author

Should we increase the major version?

Copy link
Owner

@davydovanton davydovanton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@GQuirino thanks for this update! Don't worry about CHANGELOOG file. I'll update it later

@davydovanton davydovanton merged commit 514bb39 into davydovanton:master Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants