Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add FMS datasets #1

Merged
merged 26 commits into from
May 31, 2024
Merged

Add FMS datasets #1

merged 26 commits into from
May 31, 2024

Conversation

daviswer
Copy link
Owner

@daviswer daviswer commented May 21, 2024

This PR introduces an experimental PyTorch-native dataloader from IBM that is distributed, stateful, checkpointable, composable and rescalable. It is intended for use in large-scale model pretraining, particularly in research settings where rapid iteration between datasets may be required. It automatically and invisibly handles data sharding, shuffling, subdataset weighting, checkpoint saving and loading, and more, with minimal overhead and high throughput.

  • Add experimental dataset source file
  • Add experimental dataloader builder, hooked into torchtitan cfg
  • Update torchtitan cfg with additional dataset arg fields
  • Update train script to build experimental dataloader instead of hf depending on cfg flags
  • Replace the existing C4-mini example dataset with one that matches the expected formatting for the experimental dataloader
  • TODO: port over unit tests as well
  • TODO: preprocessing script(s) for the new dataset format

@daviswer daviswer merged commit 2e733d4 into main May 31, 2024
@daviswer daviswer deleted the fms-datasets branch May 31, 2024 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants