-
Notifications
You must be signed in to change notification settings - Fork 79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix SonarQube error #450
Fix SonarQube error #450
Conversation
…avidusb-geek/emhass into davidusb-geek/fix/sonar_fixes1
This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation. |
@davidusb-geek , given time ill look into SonarQube web recommendations later. Im also looking into how we can send more data via rest. ie: |
Ok
What do you mean by this? A new method to make it simpler to send data un a curl command? |
So currently users are hitting the limitations of sending too much data in one packet / request. using |
This is an example of this: 7ca105f |
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #450 +/- ##
==========================================
+ Coverage 65.79% 65.83% +0.04%
==========================================
Files 8 8
Lines 3049 3053 +4
==========================================
+ Hits 2006 2010 +4
Misses 1043 1043 ☔ View full report in Codecov by Sentry. |
Hi @GeoDerp, is this ready to merge? |
Should be, would like to do one more double check that nothing is broken in the js files however. |
@davidusb-geek , cant change google osv just yet. They havent released a new version. Will keep en eye out for when it happens. |
Quick look looks good on this PR. |
@davidusb-geek there may be a cpu maxed out issue from the most reagent release. I not 100% sure what the cause is. But it sounds like it's a CBC package issue. |
Did you saw this on your own install? Or it was reported to you? |
Co-authored-by: scruysberghs <steven@smartenergycontrol.be>
|
No description provided.