Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix SonarQube error #450

Merged
merged 22 commits into from
Feb 16, 2025
Merged

Fix SonarQube error #450

merged 22 commits into from
Feb 16, 2025

Conversation

GeoDerp
Copy link
Contributor

@GeoDerp GeoDerp commented Feb 7, 2025

No description provided.

@github-advanced-security
Copy link

This pull request sets up GitHub code scanning for this repository. Once the scans have completed and the checks have passed, the analysis results for this pull request branch will appear on this overview. Once you merge this pull request, the 'Security' tab will show more code scanning analysis results (for example, for the default branch). Depending on your configuration and choice of analysis tool, future pull requests will be annotated with code scanning analysis results. For more information about GitHub code scanning, check out the documentation.

@GeoDerp
Copy link
Contributor Author

GeoDerp commented Feb 7, 2025

@davidusb-geek , given time ill look into SonarQube web recommendations later. Im also looking into how we can send more data via rest. ie: curl ... -H "Transfer-Encoding: chunked"

@davidusb-geek
Copy link
Owner

Ok

Im also looking into how we can send more data via rest. ie: curl ... -H "Transfer-Encoding: chunked"

What do you mean by this? A new method to make it simpler to send data un a curl command?

@GeoDerp
Copy link
Contributor Author

GeoDerp commented Feb 7, 2025

Ok

Im also looking into how we can send more data via rest. ie: curl ... -H "Transfer-Encoding: chunked"

What do you mean by this? A new method to make it simpler to send data un a curl command?

So currently users are hitting the limitations of sending too much data in one packet / request. using -H "Transfer-Encoding: chunked" in the curl command tells the call to split the data into chunks (so multiple packets for one call). However I defiantly still need to look into it.

@GeoDerp
Copy link
Contributor Author

GeoDerp commented Feb 7, 2025

This is an example of this: 7ca105f

Copy link

codecov bot commented Feb 8, 2025

Codecov Report

Attention: Patch coverage is 54.54545% with 10 lines in your changes missing coverage. Please review.

Project coverage is 65.83%. Comparing base (93f7d30) to head (61cff61).
Report is 4 commits behind head on master.

Files with missing lines Patch % Lines
src/emhass/command_line.py 54.54% 10 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##           master     #450      +/-   ##
==========================================
+ Coverage   65.79%   65.83%   +0.04%     
==========================================
  Files           8        8              
  Lines        3049     3053       +4     
==========================================
+ Hits         2006     2010       +4     
  Misses       1043     1043              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@davidusb-geek
Copy link
Owner

Hi @GeoDerp, is this ready to merge?

@GeoDerp
Copy link
Contributor Author

GeoDerp commented Feb 9, 2025

Hi @GeoDerp, is this ready to merge?

Should be, would like to do one more double check that nothing is broken in the js files however.

@GeoDerp
Copy link
Contributor Author

GeoDerp commented Feb 10, 2025

@davidusb-geek , cant change google osv just yet. They havent released a new version. Will keep en eye out for when it happens.

@GeoDerp
Copy link
Contributor Author

GeoDerp commented Feb 10, 2025

Quick look looks good on this PR.

@GeoDerp
Copy link
Contributor Author

GeoDerp commented Feb 10, 2025

@davidusb-geek there may be a cpu maxed out issue from the most reagent release. I not 100% sure what the cause is. But it sounds like it's a CBC package issue.

@davidusb-geek
Copy link
Owner

@davidusb-geek there may be a cpu maxed out issue from the most reagent release. I not 100% sure what the cause is. But it sounds like it's a CBC package issue.

Did you saw this on your own install? Or it was reported to you?
My install is running fine on the latest release, no maxed out CPU issue

Copy link

@davidusb-geek davidusb-geek merged commit 795f28a into davidusb-geek:master Feb 16, 2025
14 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants