Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(SonarQube): add SonarQube to readme #443

Merged
merged 9 commits into from
Feb 2, 2025

Conversation

GeoDerp
Copy link
Contributor

@GeoDerp GeoDerp commented Feb 1, 2025

No description provided.

@GeoDerp
Copy link
Contributor Author

GeoDerp commented Feb 2, 2025

Code Quality Scan can seem to find your secret token SONAR_TOKEN.

Copy link

codecov bot commented Feb 2, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 65.82%. Comparing base (f0b8e0d) to head (18bb858).

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #443   +/-   ##
=======================================
  Coverage   65.82%   65.82%           
=======================================
  Files           8        8           
  Lines        3058     3058           
=======================================
  Hits         2013     2013           
  Misses       1045     1045           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@GeoDerp
Copy link
Contributor Author

GeoDerp commented Feb 2, 2025

Maybe the SONAR_TOKEN secret could be set in the emhass repository settings?

Copy link

sonarqubecloud bot commented Feb 2, 2025

@davidusb-geek
Copy link
Owner

davidusb-geek commented Feb 2, 2025

Maybe the SONAR_TOKEN secret could be set in the emhass repository settings?

So is not finding the token? I understood the opposite on your previous message

@GeoDerp
Copy link
Contributor Author

GeoDerp commented Feb 2, 2025

Yeah pretty much, it's just leaving the secrets
SONAR_TOKEN value as blank on the action.

@GeoDerp
Copy link
Contributor Author

GeoDerp commented Feb 2, 2025

I wouldn't be too worried about the issue however, feel free to merge, test functionality and push a new release if you like. Could always come back to it.

@GeoDerp
Copy link
Contributor Author

GeoDerp commented Feb 2, 2025

Screenshot_20250203-060948.png

@davidusb-geek
Copy link
Owner

But it is there:

image

@GeoDerp
Copy link
Contributor Author

GeoDerp commented Feb 2, 2025

Hmmmm, yeah I'm concerned it may be a permissions issue then (or my action sucks🤣). Feel free to merge and I'll have a deeper look into this later.

@davidusb-geek davidusb-geek merged commit 3464b40 into davidusb-geek:master Feb 2, 2025
15 of 16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants