Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PVLib DBs append custom EMHASS modules and inverters #419

Merged
merged 9 commits into from
Jan 5, 2025

Conversation

GeoDerp
Copy link
Contributor

@GeoDerp GeoDerp commented Jan 4, 2025

Ability to add inverters / modules that otherwise wont be added to SAM.
(Will review my work tommorow when im more awake)

Discussed by @RafAustralia,
Related to issue: NREL/SAM#1989

@GeoDerp
Copy link
Contributor Author

GeoDerp commented Jan 4, 2025

I could look into automating this procedure also. But that may be a future goal.

@davidusb-geek
Copy link
Owner

Good idea.
My question is: where do you obtain the parameters for the new inverters?

@RafAustralia
Copy link

Good idea. My question is: where do you obtain the parameters for the new inverters?

Hi David

The parameters could be obtained either from manufacturers directly if they are willing to share / provide or simply google / chatgpt as most parameters are publicly searchable - all but certs such as C0, C1, C2, C3 which can be approximated for now.

Ive just emailed Sungrow to confirm these so we can have a better idea if what Ive found is correct.
Given we deal with China they are on holidays and may take some time to revert back. But they will.

That will update Sungrow inverters to new data and make emhass much much more accurate.

Raf

@GeoDerp GeoDerp marked this pull request as ready for review January 5, 2025 01:26
@GeoDerp
Copy link
Contributor Author

GeoDerp commented Jan 5, 2025

@davidusb-geek @RafAustralia , I have added an git action that will now (or should) automatically update cec_inverters.pbz2 and cec_modules.pbz2 files.
This will mean you should not need to do it manually in the future @davidusb-geek

@GeoDerp GeoDerp changed the title CEC append custom EMHASS modules and inverters PVLib DBs append custom EMHASS modules and inverters Jan 5, 2025
@GeoDerp
Copy link
Contributor Author

GeoDerp commented Jan 5, 2025

Sorry about all the commits. Thats what I get for going too fast.

@GeoDerp
Copy link
Contributor Author

GeoDerp commented Jan 5, 2025

PR is good to go 👍

@RafAustralia
Copy link

Let me just say that is bloody exciting!
well done both of u lot.

@davidusb-geek
Copy link
Owner

Good idea. My question is: where do you obtain the parameters for the new inverters?

Hi David

The parameters could be obtained either from manufacturers directly if they are willing to share / provide or simply google / chatgpt as most parameters are publicly searchable - all but certs such as C0, C1, C2, C3 which can be approximated for now.

Ive just emailed Sungrow to confirm these so we can have a better idea if what Ive found is correct. Given we deal with China they are on holidays and may take some time to revert back. But they will.

That will update Sungrow inverters to new data and make emhass much much more accurate.

Raf

The parameters are obtained my using real measurements in a laboratory test bench. So yes either the manufacturer or a lab entity as the NREL. These are not easy parameters to obtain. But yes they can be approximated.

@davidusb-geek
Copy link
Owner

PR is good to go 👍

Great!

@davidusb-geek davidusb-geek merged commit a6b5e80 into davidusb-geek:master Jan 5, 2025
@davidusb-geek
Copy link
Owner

It seems that the "Update EMHASS PVLib databases" job is failing when trying to git push at the end

@GeoDerp
Copy link
Contributor Author

GeoDerp commented Jan 5, 2025

It seems that the "Update EMHASS PVLib databases" job is failing when trying to git push at the end

@davidusb-geek 's completely fine.
Sorry I was going to mention that this action will fail if no update needs to be done to the database.

Since i have already updated them it will fail

@GeoDerp
Copy link
Contributor Author

GeoDerp commented Jan 5, 2025

It seems that the "Update EMHASS PVLib databases" job is failing when trying to git push at the end

@davidusb-geek 's completely fine.
Sorry I was going to mention that this action will fail if no update needs to be done to the database.

Since u have already updated them it will fail

I might look into the future to edit the action so that it passes even tho it failed

@RafAustralia
Copy link

Good idea. My question is: where do you obtain the parameters for the new inverters?

Hi David
The parameters could be obtained either from manufacturers directly if they are willing to share / provide or simply google / chatgpt as most parameters are publicly searchable - all but certs such as C0, C1, C2, C3 which can be approximated for now.
Ive just emailed Sungrow to confirm these so we can have a better idea if what Ive found is correct. Given we deal with China they are on holidays and may take some time to revert back. But they will.
That will update Sungrow inverters to new data and make emhass much much more accurate.
Raf

The parameters are obtained my using real measurements in a laboratory test bench. So yes either the manufacturer or a lab entity as the NREL. These are not easy parameters to obtain. But yes they can be approximated.

100% agree.
but actually more then half of these are publicly available if you search with exception of C values. But Im trying to get these confirmed also as well.
so with a bit of effort we will update the list to new data which is exciting

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants