Compute R-err and print it to iterations.json #233
Merged
+817
−754
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…bal maximum Fixes P-err calculation in compute_primal_residues_and_error_P_Ax_X(), where AllReduce was forgotten. This bug probably did not affect solver behaviour: in our integration tests, P-err was the same across all ranks up to the last ~100 bits.
…ion() makes compute_search_direction() ~15% faster
Fixes compilation fail on MacOS
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
R-err = maxAbs(mu * I - XY)and print it toout/iterations.jsonXYonce and reuse it forR-err,muandcompute_search_direction().This should make
compute_search_direction()~10-15% faster.P-errcomputation: old version ofcompute_primal_residues_and_error_P_Ax_X()did not callAllReduce()to find maximum across all ranks. Now we callAllReduce()inBlock_Diagonal_Matrix::max_abs().This bug probably did not affect solver behaviour: in our integration tests at precision=768, P-err was the same across all ranks up to the last ~100 bits.