Minor memory-related fixes and improvements: pretty-print bytes, #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oth GB and bytes, for better readability. Also remove extra newlines coming from El::Print Add pretty_print_bytes() function to sdpb_util/ostream
e.g: maxSharedMemory = 25.0 GB (26843545600 bytes)
It was used to print shared window sizes, but now we print them in BigInt_Shared_Memory_Syrk_Context constructor.
- Remove outdated comment about copies of Q - Fix BigFloat size calculation: use actual size instead of serialized. Actual size is 12B larger. - Accounted for more PSD blocks: primal_residues, dX, dY, R, Z - pretty print bytes R,Z - from compute_search_direction(), TODO we shall account for them only if peak usage is there.
…ix allocation + deallocate_unused_half()) + code cleanup + reformat
block_views should contain views of input block matrices, but extra copy was made by mistake.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
maxSharedMemory = 25.0 GB (26843545600 bytes)pmp2sdpcompute_block_residues().In theory, this should reduce peak RAM usage at this step, but in practice it (almost) doesn't.