Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #219 Updating block_timings leads to checkpoint loading errors #220

Merged
merged 1 commit into from
Apr 1, 2024
Merged

Fix #219 Updating block_timings leads to checkpoint loading errors #220

merged 1 commit into from
Apr 1, 2024

Conversation

vasdommes
Copy link
Collaborator

The bug was introduced in #215, see commit 522dc98

Now we revert these changes and do not update ck/block_timings after actual run. It is written only after a timing run.
(Note that we are still writing new profiling data)

Also updated end-to-end.test.cxx: run SDPB twice for SingletScalar_cT_test_nmax6/primal_dual_optimal to test this bug

@vasdommes
Fix #219 Updating block_timings leads to checkpoint loading errors
1410120 
The bug was introduced in #215, see commit 522dc98

Now we revert these changes and do not update ck/block_timings after actual run. It is written only after a timing run.

end-to-end.test.cxx: run SDPB twice for SingletScalar_cT_test_nmax6/primal_dual_optimal to test this bug
@vasdommes vasdommes added this to the 3.0.0 milestone Apr 1, 2024
@vasdommes vasdommes self-assigned this Apr 1, 2024
@vasdommes vasdommes merged commit 2721704 into master Apr 1, 2024
2 checks passed
@vasdommes vasdommes deleted the fix-block-timings branch April 1, 2024 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@vasdommes vasdommes

Labels
bug regression
Projects
None yet
Milestone
3.0.0
Development

Successfully merging this pull request may close these issues.

Updating block_timings leads to checkpoint loading errors
1 participant
@vasdommes